Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Make proto-gen generates invalid files #11469

Closed
4 tasks
joe-bowman opened this issue Mar 26, 2022 · 0 comments · Fixed by #11472
Closed
4 tasks

bug: Make proto-gen generates invalid files #11469

joe-bowman opened this issue Mar 26, 2022 · 0 comments · Fixed by #11472
Assignees

Comments

@joe-bowman
Copy link
Contributor

joe-bowman commented Mar 26, 2022

Summary

#11452 updated the dockerfile for generating protobug files, but did not commit all affected files.

(I didn't want to include these as part of my PR for adding a feature).

Ran make proto-gen and the files that are generated fail to build:

Build Error: go test -c -o /tmp/__debug_bin1697164184 -gcflags all=-N -l .
# github.com/cosmos/cosmos-sdk/types
../../../../types/coin.pb.go:302:8: invalid argument m.Amount (type Int) for len
../../../../types/coin.pb.go:303:11: invalid argument m.Amount (type Int) for len
../../../../types/coin.pb.go:304:7: second argument to copy should be slice or string; have struct { i *big.Int }
../../../../types/coin.pb.go:305:43: invalid argument m.Amount (type Int) for len
../../../../types/coin.pb.go:339:8: invalid argument m.Amount (type Dec) for len
../../../../types/coin.pb.go:340:11: invalid argument m.Amount (type Dec) for len
../../../../types/coin.pb.go:341:7: second argument to copy should be slice or string; have struct { i *big.Int }
../../../../types/coin.pb.go:342:43: invalid argument m.Amount (type Dec) for len
../../../../types/coin.pb.go:376:8: invalid argument m.Int (type Int) for len
../../../../types/coin.pb.go:377:11: invalid argument m.Int (type Int) for len
../../../../types/coin.pb.go:377:11: too many errors (exit status 2)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
joe-bowman pushed a commit to ingenuity-build/cosmos-sdk that referenced this issue Mar 26, 2022
@joe-bowman joe-bowman changed the title chore: regen all pb.go files bug: Make proto-gen generates invalid files Mar 26, 2022
@tac0turtle tac0turtle mentioned this issue Mar 26, 2022
19 tasks
@tac0turtle tac0turtle self-assigned this Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants