fix: Protobuf docker #11472
Merged
fix: Protobuf docker #11472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
added
the
A:automerge
alexanderbez
approved these changes
Mar 26, 2022
Codecov Report
@@ Coverage Diff @@
## master #11472 +/- ##
==========================================
- Coverage 65.91% 65.85% -0.07%
==========================================
Files 710 675 -35
Lines 72718 69830 -2888
==========================================
- Hits 47934 45988 -1946
+ Misses 21817 21142 -675
+ Partials 2967 2700 -267 |
|
I think we should have more look into it. I was testing it with locally build docker and it worked perfectly. So not sure why we were reverting this. Moreover this reverted the version update. |
| @@ -9,21 +9,18 @@ RUN apk add --no-cache \ | |||
| make | |||
|
|
|||
| ENV GOLANG_PROTOBUF_VERSION=1.28.0 \ | |||
| GOGO_PROTOBUF_VERSION=1.3.3-alpha.regen.1 \ | |||
There was a problem hiding this comment.
why changing this version?
| # github.com/regen-network/protobuf/protoc-gen-gogofast@v${GOGO_PROTOBUF_VERSION} \ | ||
| # github.com/regen-network/protobuf/protoc-gen-gogofaster@v${GOGO_PROTOBUF_VERSION} | ||
|
|
||
| RUN git clone https://github.com/regen-network/protobuf.git; cd protobuf; go mod download; make install |
There was a problem hiding this comment.
I prefer to install all proto dependenies in the docker when creating the image.
|
because it wasn't working, I tested locally and it wasn't generating things correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #11469
revert changes
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change