Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to poetry #47

Merged
merged 6 commits into from
Dec 2, 2022
Merged

Migrate to poetry #47

merged 6 commits into from
Dec 2, 2022

Conversation

indiVar0508
Copy link
Contributor

Migrate to poetry

  1. update pyproject.toml
  2. ignore virtual env file artifacts
  3. update github actions
  4. delete requirements folder

@indiVar0508 indiVar0508 force-pushed the migrate_to_poetry branch 13 times, most recently from d55da3a to 25afe97 Compare November 19, 2022 11:36
@indiVar0508 indiVar0508 force-pushed the migrate_to_poetry branch 2 times, most recently from 1d189f8 to e691b70 Compare November 24, 2022 09:33
@indiVar0508 indiVar0508 marked this pull request as draft November 24, 2022 12:10
@indiVar0508 indiVar0508 linked an issue Dec 1, 2022 that may be closed by this pull request
Move to pyproject.toml with poetry #11
Closed
@AbdealiLoKo @indiVar0508
Add(#5): Add Oracle to github actions
7f71030 
Add Oracle to github actions and test using Pytest
Add connection URL for oracle - if the DB being used is oracle
Add Cx-Oracle requirement in test.txt
Add dependencies for oracle in github actions
@indiVar0508 indiVar0508 force-pushed the migrate_to_poetry branch 10 times, most recently from 1bf8dd9 to c8f92ec Compare December 2, 2022 08:34
indiVar0508 and others added 5 commits December 2, 2022 14:16
@indiVar0508
chore(#11): migrate to poetry
28ca768 
Update configurations in `pyproject.toml` to enable poetry.
Not using group as it causes issue in installation in github
action job.
refer: https://github.com/corridor/sqlalchemy-history/actions/runs/3600114588/jobs/6064420550
@AbdealiLoKo @indiVar0508
chore: Update license file to Apache-2
f1888a7 
We use Apache-2 for sqlalchemy-history but any code from
sqlalchemy-continuum remains as BSD-3 license
@indiVar0508
chore(#11): Ignore lock file created by poetry
8a98c9a 
ignore lock file from poetry
ignore variant of poetry folder name
@indiVar0508
chore(#11): Update github action job to use poetry
f9b496d 
Use poetry in github action to setup dependencies
Keep the poetry venv inside the project
@indiVar0508
chore(#11): Delete requirements folder
0427d7d 
Remove requirements folder as poetry manages it now.
@indiVar0508 indiVar0508 linked an issue Dec 2, 2022 that may be closed by this pull request
Update CI for test and extend support for MSSQL and Oracle #39
Closed
3 tasks
@indiVar0508 indiVar0508 marked this pull request as ready for review December 2, 2022 08:53
@indiVar0508
Copy link
Contributor Author

Couple of changes made in PR commits

  1. Added Oracle Action Job in Commit in this PR
  2. Removed poetry action install due to poetry command not found issue, have raised issue for help in poetry: command not found snok/install-poetry#109
  3. Removed group key in pyproject.toml configuration as poetry was throwing execption in action Job refer: https://github.com/corridor/sqlalchemy-history/actions/runs/3600114588/jobs/6064420550

@indiVar0508 indiVar0508 merged commit 7f73b0f into master Dec 2, 2022
@indiVar0508 indiVar0508 deleted the migrate_to_poetry branch December 2, 2022 09:18
@indiVar0508 indiVar0508 linked an issue Dec 2, 2022 that may be closed by this pull request
Add github actions for oracle #5
Closed
@indiVar0508 indiVar0508 mentioned this pull request Dec 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbdealiLoKo AbdealiLoKo AbdealiLoKo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@indiVar0508 @AbdealiLoKo