Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI for test and extend support for MSSQL and Oracle #39

Closed
3 tasks done
indiVar0508 opened this issue Nov 10, 2022 · 0 comments · Fixed by #47
Closed
3 tasks done

Update CI for test and extend support for MSSQL and Oracle #39

indiVar0508 opened this issue Nov 10, 2022 · 0 comments · Fixed by #47
Assignees
@indiVar0508

Comments

@indiVar0508
Copy link
Contributor

indiVar0508 commented Nov 10, 2022 •
edited
Loading

Need to optimize github workflow for test

  • - Intialize containers for particular DB for a given test
  • - Extend Support for MSSQL DB in actions
  • - Extend Support for Oracle DB in actions
indiVar0508 added a commit that referenced this issue Nov 10, 2022
@indiVar0508
Chore(#39): optimize github action workflow for tests
3df3c3f 
seperate jobs based on DB type
indiVar0508 added a commit that referenced this issue Nov 10, 2022
@indiVar0508
Chore(#39): optimize github action workflow for tests
ee1a781 
seperate jobs based on DB type
indiVar0508 added a commit that referenced this issue Nov 10, 2022
@indiVar0508
Chore(#39): optimize github action workflow for tests
22c93ab 
seperate jobs based on DB type
indiVar0508 added a commit that referenced this issue Nov 10, 2022
@indiVar0508
Chore(#39): optimize github action workflow for tests
039699d 
seperate jobs based on DB type
indiVar0508 added a commit that referenced this issue Nov 10, 2022
@indiVar0508
Chore(#39): optimize github action workflow for tests
06e0ff6 
seperate jobs based on DB type
indiVar0508 added a commit that referenced this issue Nov 14, 2022
@indiVar0508
Chore(#39): Add MSSQL action job check
f74dc32 
Add MSSQL action job against Pytest for validity
indiVar0508 added a commit that referenced this issue Nov 14, 2022
@indiVar0508
Chore(#39): Add MSSQL action job check
2e91a73 
Add MSSQL action job against Pytest for validity
Add test condn in test module for mssql
indiVar0508 added a commit that referenced this issue Nov 14, 2022
@indiVar0508
Chore(#39): Add MSSQL action job check
661a566 
Add MSSQL action job against Pytest for validity
Add test condn in test module for mssql
indiVar0508 added a commit that referenced this issue Nov 14, 2022
@indiVar0508
Chore(#39): Add MSSQL action job check
26ebbc0 
Add MSSQL action job against Pytest for validity
Add test condn in test module for mssql
indiVar0508 added a commit that referenced this issue Nov 15, 2022
@indiVar0508
Chore(#39): Add Oracle action job check
00f0f66 
Add Oracle action job against Pytest for validity
Add test condn in test module for oracle
Add Cx-Oracle requirement in test.txt
indiVar0508 added a commit that referenced this issue Nov 15, 2022
@indiVar0508
Chore(#39): Add Oracle action job check
786edbe 
Add Oracle action job against Pytest for validity
Add test condn in test module for oracle
Add Cx-Oracle requirement in test.txt
indiVar0508 added a commit that referenced this issue Nov 16, 2022
@indiVar0508
Chore(#39): Add Oracle action job check
caa2d13 
Add Oracle action job against Pytest for validity
Add test condn in test module for oracle
Add Cx-Oracle requirement in test.txt
AbdealiLoKo pushed a commit that referenced this issue Nov 17, 2022
@indiVar0508 @AbdealiLoKo
Chore(#39): Optimize github action workflow for tests
bf26844 
Seperate jobs based on DB type.
This avoid initializing all the services in every job.

This also makes it more stable, because sometimes mysql does not start.
Earlier, mysql not starting in other-DB tests cause the test to fail.
Now, Only the mysql test will be affected if mysql service doesnt start
AbdealiLoKo pushed a commit that referenced this issue Nov 17, 2022
@indiVar0508 @AbdealiLoKo
Chore(#39): Optimize github action workflow for tests
1e7e561 
Seperate jobs based on DB type.
This avoid initializing all the services in every job.

This also makes it more stable, because sometimes mysql does not start.
Earlier, mysql not starting in other-DB tests cause the test to fail.
Now, Only the mysql test will be affected if mysql service doesnt start
indiVar0508 added a commit that referenced this issue Nov 18, 2022
@indiVar0508
chore(#39): install python version specified
a20dc9e 
original yaml file was not installing specified version in action
matrix.
added action to install specified version for python.

bumping python 3.6.2 to 3.6.7 as following are the versions valid for
the new action used.
https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json
indiVar0508 added a commit that referenced this issue Nov 18, 2022
@indiVar0508
chore(#39): install python version specified
fb4d13f 
original yaml file was not installing specified version in action
matrix.
added action to install specified version for python.

bumping python 3.6.2 to 3.6.7 as following are the versions valid for
the new action used.
https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json
indiVar0508 added a commit that referenced this issue Nov 18, 2022
@indiVar0508
chore(#39): install python version specified
76411e7 
original yaml file was not installing specified version in action
matrix.
added action to install specified version for python.

bumping python 3.6.2 to 3.6.7 as following are the versions valid for
the new action used.
https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json
indiVar0508 added a commit that referenced this issue Nov 18, 2022
@indiVar0508
chore(#39): install python version specified
c8f5978 
original yaml file was not installing specified version in action
matrix.
added action to install specified version for python.

bumping python 3.6.2 to 3.6.7 as following are the versions valid for
the new action used.
https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

Use ubuntu-20.04 to install python 3.10 refer to issue
`https://github.com/actions/setup-python/issues/541`
indiVar0508 added a commit that referenced this issue Nov 18, 2022
@indiVar0508
chore(#39): install python version specified
3fad5b1 
original yaml file was not installing specified version in action
matrix.
added action to install specified version for python.

bumping python 3.6.2 to 3.6.7 as following are the versions valid for
the new action used.
https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

Use ubuntu-20.04 to install python 3.10 refer to issue
`https://github.com/actions/setup-python/issues/541`
indiVar0508 added a commit that referenced this issue Nov 18, 2022
@indiVar0508
Chore(#39): optimize github action workflow for tests
de9c40d 
seperate jobs based on DB type
indiVar0508 added a commit that referenced this issue Nov 19, 2022
@indiVar0508
chore(#39): install python version specified
3a63aea 
original yaml file was not installing specified version in action
matrix.
add action to install specified version for python.

Use ubuntu-20.04 to install python 3.10 refer to issue
`https://github.com/actions/setup-python/issues/541`
@indiVar0508 indiVar0508 self-assigned this Nov 24, 2022
AbdealiLoKo pushed a commit that referenced this issue Nov 24, 2022
@indiVar0508 @AbdealiLoKo
chore(#39): install python version specified
6a48608 
original yaml file was not installing specified version in action
matrix.
add action to install specified version for python.

Use ubuntu-20.04 to install python 3.10 refer to issue
`https://github.com/actions/setup-python/issues/541`
@indiVar0508 indiVar0508 linked a pull request Dec 2, 2022 that will close this issue
Migrate to poetry #47
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@indiVar0508 indiVar0508

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate to poetry corridor/sqlalchemy-history
1 participant
@indiVar0508