Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to pyproject.toml with poetry #11

Closed
AbdealiLoKo opened this issue Oct 7, 2022 · 3 comments · Fixed by #47
Closed

Move to pyproject.toml with poetry #11

AbdealiLoKo opened this issue Oct 7, 2022 · 3 comments · Fixed by #47
Assignees
@indiVar0508

Comments

@AbdealiLoKo
Copy link
Contributor

Common libraries use today for building wheel files

  • setup.py
  • poetry
  • pyproject.toml
  • setup.cfg
@indiVar0508
Copy link
Contributor

I think we should go with pyproject.toml as transformation from what we have to this will be fairly straight forward

@AbdealiLoKo AbdealiLoKo changed the title Decide on build system Move to pyproject.toml Oct 17, 2022
@MuhammedAadil
Copy link

I would like to get assigned to this

@indiVar0508
Copy link
Contributor

Hey @MuhammedAadil ,
Since there is no activity from your side regarding issue reassigning issue to myself

indiVar0508 added a commit that referenced this issue Nov 8, 2022
@indiVar0508
chore(#11): adopt pyproject.toml
ced8ff5 
Added Pyproject.toml and migrated configurations from setup.py to it
Updated requirements.txt to contain package requirements
Updated pkg version to release candidate one
Have left original Author of project and added Corridor as new author.
indiVar0508 added a commit that referenced this issue Nov 8, 2022
@indiVar0508
chore(#11): adopt pyproject.toml
337d785 
Added Pyproject.toml and migrated configurations from setup.py to it
Updated requirements.txt to contain package requirements
Updated pkg version to release candidate one
Have left original Author of project and added Corridor as new author.
Added docs optional dependency to generate static documentation
indiVar0508 added a commit that referenced this issue Nov 9, 2022
@indiVar0508
chore(#11): adopt pyproject.toml
502b566 
Added Pyproject.toml and migrated configurations from setup.py to it
Updated requirements.txt to contain package requirements
Updated pkg version to release candidate one
Have left original Author of project and added Corridor as new author.
Added docs optional dependency to generate static documentation
AbdealiLoKo pushed a commit that referenced this issue Nov 10, 2022
@indiVar0508 @AbdealiLoKo
chore(#11): Adopt pyproject.toml for build systems
4be4750 
 - Add Pyproject.toml and migrate configurations from setup.py to it
 - Update pkg version to release candidate one
AbdealiLoKo pushed a commit that referenced this issue Nov 10, 2022
@indiVar0508 @AbdealiLoKo
chore(#11): Adopt pyproject.toml for build systems
ee85043 
 - Add Pyproject.toml and migrate configurations from setup.py to it
 - Update pkg version to release candidate one
AbdealiLoKo pushed a commit that referenced this issue Nov 10, 2022
@indiVar0508 @AbdealiLoKo
chore(#11): Adopt pyproject.toml for build systems
0054acc 
 - Add Pyproject.toml and migrate configurations from setup.py to it
 - Update pkg version to release candidate one
indiVar0508 added a commit that referenced this issue Nov 17, 2022
@indiVar0508
chore(#11): migrate to pyproject.toml
7f72d51 
update configurations in `pyproject.toml` to enable poetry.
indiVar0508 added a commit that referenced this issue Nov 17, 2022
@indiVar0508
chore(#11): ignore virtual env files
9772450 
ignore lock file from poetry
ignore variant of poetry folder name
indiVar0508 added a commit that referenced this issue Nov 17, 2022
@indiVar0508
chore(#11): update github action job to use poetry
2c54fec 
use poetry install in github action
indiVar0508 added a commit that referenced this issue Nov 17, 2022
@indiVar0508
chore(#11): delete requirements folder
ed21a09 
remove requirements folder as pyproject contains dependencies
indiVar0508 added a commit that referenced this issue Nov 17, 2022
@indiVar0508
chore(#11): migrate to pyproject.toml
3bd455b 
update configurations in `pyproject.toml` to enable poetry.
indiVar0508 added a commit that referenced this issue Nov 17, 2022
@indiVar0508
chore(#11): ignore virtual env files
849c49c 
ignore lock file from poetry
ignore variant of poetry folder name
indiVar0508 added a commit that referenced this issue Nov 17, 2022
@indiVar0508
chore(#11): update github action job to use poetry
ec2b2bc 
use poetry install in github action
update python3.6.2 due to black conflict
indiVar0508 added a commit that referenced this issue Nov 17, 2022
@indiVar0508
chore(#11): delete requirements folder
4871080 
remove requirements folder as pyproject contains dependencies
indiVar0508 added a commit that referenced this issue Nov 17, 2022
@indiVar0508
chore(#11): update github action job to use poetry
a6aa86f 
use poetry install in github action
update python3.6.2 due to black conflict
indiVar0508 added a commit that referenced this issue Nov 17, 2022
@indiVar0508
chore(#11): delete requirements folder
f3647ca 
remove requirements folder as pyproject contains dependencies
indiVar0508 added a commit that referenced this issue Nov 17, 2022
@indiVar0508
chore(#11): update github action job to use poetry
80d00a4 
use poetry install in github action
update python3.6.2 due to black conflict
activate the virtual environment created by poetry
indiVar0508 added a commit that referenced this issue Nov 17, 2022
@indiVar0508
chore(#11): delete requirements folder
e91ab97 
remove requirements folder as pyproject contains dependencies
indiVar0508 added a commit that referenced this issue Nov 17, 2022
@indiVar0508
chore(#11): update github action job to use poetry
0d490ca 
use poetry install in github action
update python3.6.2 due to black conflict
activate the virtual environment created by poetry
indiVar0508 added a commit that referenced this issue Nov 17, 2022
@indiVar0508
chore(#11): delete requirements folder
d3bf29c 
remove requirements folder as pyproject contains dependencies
indiVar0508 added a commit that referenced this issue Nov 18, 2022
@indiVar0508
chore(#11): update github action job to use poetry
b633151 
use poetry install in github action
update python3.6.2 due to black conflict
activate the virtual environment created by poetry
indiVar0508 added a commit that referenced this issue Nov 18, 2022
@indiVar0508
chore(#11): delete requirements folder
ed92a20 
remove requirements folder as pyproject contains dependencies
indiVar0508 added a commit that referenced this issue Nov 18, 2022
@indiVar0508
chore(#11): update github action job to use poetry
85bb20e 
use poetry install in github action
update python3.6.2 due to black conflict
activate the virtual environment created by poetry
indiVar0508 added a commit that referenced this issue Dec 1, 2022
@indiVar0508
chore(#11): Delete requirements folder
74401df 
Remove requirements folder as poetry manages it now.
indiVar0508 added a commit that referenced this issue Dec 1, 2022
@indiVar0508
chore(#11): Update github action job to use poetry
09fbedc 
Use poetry in github action to setup dependencies
Keep the poetry venv inside the project
indiVar0508 added a commit that referenced this issue Dec 1, 2022
@indiVar0508
chore(#11): Delete requirements folder
dbe80f3 
Remove requirements folder as poetry manages it now.
indiVar0508 added a commit that referenced this issue Dec 1, 2022
@indiVar0508
chore(#11): Update github action job to use poetry
8a73705 
Use poetry in github action to setup dependencies
Keep the poetry venv inside the project
indiVar0508 added a commit that referenced this issue Dec 1, 2022
@indiVar0508
chore(#11): Delete requirements folder
67d8c43 
Remove requirements folder as poetry manages it now.
indiVar0508 added a commit that referenced this issue Dec 1, 2022
@indiVar0508
chore(#11): Update github action job to use poetry
c167428 
Use poetry in github action to setup dependencies
Keep the poetry venv inside the project
indiVar0508 added a commit that referenced this issue Dec 1, 2022
@indiVar0508
chore(#11): Delete requirements folder
de586b2 
Remove requirements folder as poetry manages it now.
indiVar0508 added a commit that referenced this issue Dec 1, 2022
@indiVar0508
chore(#11): Update github action job to use poetry
99bbc7b 
Use poetry in github action to setup dependencies
Keep the poetry venv inside the project
indiVar0508 added a commit that referenced this issue Dec 1, 2022
@indiVar0508
chore(#11): Delete requirements folder
85a37ee 
Remove requirements folder as poetry manages it now.
indiVar0508 added a commit that referenced this issue Dec 1, 2022
@indiVar0508
chore(#11): Update github action job to use poetry
42780bd 
Use poetry in github action to setup dependencies
Keep the poetry venv inside the project
indiVar0508 added a commit that referenced this issue Dec 1, 2022
@indiVar0508
chore(#11): Delete requirements folder
250856d 
Remove requirements folder as poetry manages it now.
indiVar0508 added a commit that referenced this issue Dec 2, 2022
@indiVar0508
chore(#11): Update github action job to use poetry
2e79e31 
Use poetry in github action to setup dependencies
Keep the poetry venv inside the project
indiVar0508 added a commit that referenced this issue Dec 2, 2022
@indiVar0508
chore(#11): Delete requirements folder
1bf8dd9 
Remove requirements folder as poetry manages it now.
indiVar0508 added a commit that referenced this issue Dec 2, 2022
@indiVar0508
chore(#11): migrate to poetry
ea3a324 
Update configurations in `pyproject.toml` to enable poetry.
Not using group as it causes issue in installation in github
action job.
refer: https://github.com/corridor/sqlalchemy-history/actions/runs/3600114588/jobs/6064420550
indiVar0508 added a commit that referenced this issue Dec 2, 2022
@indiVar0508
chore(#11): Ignore lock file created by poetry
bb1ab8c 
ignore lock file from poetry
ignore variant of poetry folder name
indiVar0508 added a commit that referenced this issue Dec 2, 2022
@indiVar0508
chore(#11): Update github action job to use poetry
e08d960 
Use poetry in github action to setup dependencies
Keep the poetry venv inside the project
indiVar0508 added a commit that referenced this issue Dec 2, 2022
@indiVar0508
chore(#11): Delete requirements folder
c8f92ec 
Remove requirements folder as poetry manages it now.
indiVar0508 added a commit that referenced this issue Dec 2, 2022
@indiVar0508
chore(#11): migrate to poetry
2963e71 
Update configurations in `pyproject.toml` to enable poetry.
Not using group as it causes issue in installation in github
action job.
refer: https://github.com/corridor/sqlalchemy-history/actions/runs/3600114588/jobs/6064420550
indiVar0508 added a commit that referenced this issue Dec 2, 2022
@indiVar0508
chore(#11): Ignore lock file created by poetry
f5ae431 
ignore lock file from poetry
ignore variant of poetry folder name
indiVar0508 added a commit that referenced this issue Dec 2, 2022
@indiVar0508
chore(#11): Update github action job to use poetry
c1b70c2 
Use poetry in github action to setup dependencies
Keep the poetry venv inside the project
indiVar0508 added a commit that referenced this issue Dec 2, 2022
@indiVar0508
chore(#11): Delete requirements folder
4b12e6c 
Remove requirements folder as poetry manages it now.
indiVar0508 added a commit that referenced this issue Dec 2, 2022
@indiVar0508
chore(#11): migrate to poetry
28ca768 
Update configurations in `pyproject.toml` to enable poetry.
Not using group as it causes issue in installation in github
action job.
refer: https://github.com/corridor/sqlalchemy-history/actions/runs/3600114588/jobs/6064420550
indiVar0508 added a commit that referenced this issue Dec 2, 2022
@indiVar0508
chore(#11): Ignore lock file created by poetry
8a98c9a 
ignore lock file from poetry
ignore variant of poetry folder name
indiVar0508 added a commit that referenced this issue Dec 2, 2022
@indiVar0508
chore(#11): Update github action job to use poetry
f9b496d 
Use poetry in github action to setup dependencies
Keep the poetry venv inside the project
indiVar0508 added a commit that referenced this issue Dec 2, 2022
@indiVar0508
chore(#11): Delete requirements folder
0427d7d 
Remove requirements folder as poetry manages it now.
indiVar0508 added a commit that referenced this issue Dec 2, 2022
@indiVar0508
chore(#11): migrate to poetry
271eb27 
Update configurations in `pyproject.toml` to enable poetry.
Not using group as it causes issue in installation in github
action job.
refer: https://github.com/corridor/sqlalchemy-history/actions/runs/3600114588/jobs/6064420550
indiVar0508 added a commit that referenced this issue Dec 2, 2022
@indiVar0508
chore(#11): Ignore lock file created by poetry
e08816c 
ignore lock file from poetry
ignore variant of poetry folder name
indiVar0508 added a commit that referenced this issue Dec 2, 2022
@indiVar0508
chore(#11): Update github action job to use poetry
f86d0ab 
Use poetry in github action to setup dependencies
Keep the poetry venv inside the project
indiVar0508 added a commit that referenced this issue Dec 2, 2022
@indiVar0508
chore(#11): Delete requirements folder
7f73b0f 
Remove requirements folder as poetry manages it now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@indiVar0508 indiVar0508

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate to poetry corridor/sqlalchemy-history
3 participants
@AbdealiLoKo @indiVar0508 @MuhammedAadil