Resolve build errors in test project

[steverichey]

Fixes #504.

There were two issues causing build errors in the test project:

• A reference to DiffEngine 8.5.3, while an indirect reference through another dependency required 9.1.0
• Use of the now removed VerifierSettings.ModifySerialization

By upgrading the DiffEngine reference and updating the methods used to set up Verify, I am now able to build this project and run tests locally. However, some tests still fail.

I've also updated dependencies in the ExampleClient project to allow the auto-format action to succeed.

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[steverichey]

I have read the CLA Document and I hereby sign the CLA

[steverichey]

If desired, I can submit a subsequent pull request to resolve test failures.

[mscottford]

Thanks, @steverichey! Instead of a separate pull request, it's best to fix the test failures as part of this one.

[steverichey]

Well, this is confusing. Reverting to a version of the ElasticSearch client before they added pre-flight checks resolves the issues for many tests. However, the solution to the second test issue is less clear. Here's an example test failure:

Corgibytes.Freshli.Lib.Test.Integration.Languages.Ruby.RubyGemsRepositoryProperlyHandlesRateLimitsTest.FullSet
Source: RubyGemsRepositoryProperlyHandlesRateLimitsTest.cs line 24
Duration: 1.1 min
Message: 
System.MissingMethodException : Method not found: 'System.ValueTuple`2<System.String,System.String> ReflectionFileNameBuilder.FileNamePrefix(System.Reflection.MethodInfo, System.Type, System.String, VerifyTests.VerifySettings, System.String)'.

Stack Trace: 
<>c__DisplayClass0_0.b__0(String uniqueness)
InnerVerifier.ctor(String sourceFile, VerifySettings settings, GetFileConvention fileConvention) line 17
Verifier.GetVerifier(VerifySettings settings, String sourceFile) line 14
<b__0>d.MoveNext() line 31
--- End of stack trace from previous location ---

At the end of the FullSet test, we call Verifier.Verify(packagesAndResults). Under the hood, this works its way to this method which in turn expects a method ReflectionFileNameBuilder.FileNamePrefix. This method is in the Verify assembly and I was able to load it at runtime by adding these lines to the test:

var assembly = AppDomain.CurrentDomain.GetAssemblies().Single(assembly => assembly.GetName().Name == "Verify");
var rfnb = assembly.GetType("ReflectionFileNameBuilder", true);
var methd = rfnb.GetMethod("FileNamePrefix", BindingFlags.Static | BindingFlags.Public);

It's not immediately clear why this method can't be loaded. Will investigate as time allows.

[mscottford]

There might be a breaking change in the Verify package that we need to contend with. Perhaps searching for an older version of it?

[steverichey]

I'm still not sure what was causing the MissingMethodException, but it continues to be an issue until 16.2.0. As of 16.3.0, the issue goes away. This change to the .csproj file seems a likely culprit, as missing target frameworks is the most common cause of methods not being included in an assembly, in my experience. The pull request that made this change is vague, but seems designed to improve .net6 support, which we are currently using. I've updated the tests project to use 16.3.0, but this does change how some verification results are sorted, swapping 2.0.0 and 2.0, which you can see here.

[steverichey]

@mscottford Take a look at the changes when you have a chance. The most recent macOS tests failed, but it seems due to a spurious connection failure. The solution for this -- in the very long term -- would be to stub or mock external connections to avoid brittle tests, IMHO.

[mscottford]

We’re going to deprecate this library soon (a month or so). Let’s go ahead and remove the test matrix so we’re only testing against Linux. That will get this project passing well enough for us to move forward.

[mscottford]

Thanks for doing this! This looks good enough to merge after the test matrix is changed to only run Linux builds.

[mscottford]

Is there no equivalent for this call?

[steverichey]

As far as I'm aware, it was completely removed. See: VerifyTests/Verify#526