Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cla bot #563

Merged
merged 7 commits into from
Sep 8, 2022
Merged

Remove cla bot #563

merged 7 commits into from
Sep 8, 2022

Conversation

edwinkortman
Copy link
Contributor

To keep things in-line with the other Freshli repository for signing the CLA, move the CLA related documents to the central repository.
See also: corgibytes/freshli-cli#158

Edwin Kortman added 4 commits July 29, 2022 10:52
Delete CLA directory
3a04403 
We have switched over to a single repository for collecting all the signatures:
https://github.com/corgibytes/freshli-cla
Use central repository for CLA signatures
b38b52b
doc: Link to the CLA
7a78462 
Because we moved the CLA to a different repository. We at least want to
make a reference somewhere that we are expecting users to sign the CLA,
and to tell them how to sign it.
Set correct versions otherwise their dependencies are upgraded a few …
4f13fc0 
…major versions
@edwinkortman
Copy link
Contributor Author

edwinkortman commented Aug 5, 2022 •
edited
Loading

This appears to be the last commit where the build was working: 2d58322
Some struggles I've had with trying to fix this:

  • Locally, and in CI, the tests are incredibly slow to start up (+1 minute)
  • The log output in CI of "what's wrong" is lengthy. Log file is 9.9 MB
  • Resetting the dependencies to what's defined in #2d5832228457862275a61449a3ce84a680d2167c gives me a different problem. Namely that there's a timezone difference. The tests expect +00:00, and when I run them I get +01:00. This is likely due to that I'm in GMT+1 or GMT+2 depending if it's daylight saving time or not.

With our recent developments in the Freshli CLI, I'm putting this to the side for now (or at least till Scott says that's okay or not :D)

@mscottford
Copy link
Member

@steverichey after #577 is merged, will you please merge main into this branch and see if it will pass the checks? It’s a good idea to get it merged in as well.

mscottford
mscottford approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@mscottford mscottford left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice to have the CLA signatures in one place.

@mscottford mscottford mentioned this pull request Sep 8, 2022
Closed
@steverichey steverichey merged commit bb9c7dc into main Sep 8, 2022
@steverichey steverichey deleted the remove-cla-bot branch September 8, 2022 14:10
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2022
@mscottford mscottford added the documentation Improvements or additions to documentation label Sep 8, 2022
@mscottford mscottford added this to the v0.5.0 milestone Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mscottford mscottford mscottford approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@edwinkortman @mscottford @steverichey