Fix project build and test issues [closes #504] #506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
marnen
changed the title
marnen
force-pushed
the
504-build-issues
branch
from
5311638 to
b36c551
Compare
Closed
marnen
force-pushed
the
504-build-issues
branch
from
b36c551 to
34ec3b0
Compare
|
BTW, note that both the issues fixed in this pull request come from Dependabot changes being automerged even though the builds failed. How can we prevent this in future? |
|
Ah, it appears that our current Dependabot workflow approves all patch and minor updates, regardless of the build status. We need to fix that so Dependabot doesn't break the build. |
This was referenced Mar 10, 2022
|
This is superseded by #577. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #504.