upload-oscontainer: New command

[cgwalters]

This code lives today in the RHCOS pipeline (internal gitlab);
to be honest, I have no idea why only the "core" oscontainer bits
ended up in cosa upstream and the script lived downstream.

Let's fix that, moving all of the logic here. Prep for
further work.

[miabbott]

Should add upload-oscontainer to https://github.com/coreos/coreos-assembler/blob/master/src/coreos-assembler#L45 or so.

[miabbott]

I needed $ chmod +x src/cmd-upload-oscontainer too

[cgwalters]

OK, fixed those two bits plus some pylint stuff.

[miabbott]

The use of buildah unshare got me building the oscontainer from within a cosa container, but it ultimately bombed out trying to podman inspect:

$ coreos-assembler oscontainer build --from scratch /srv/tmp/repo f8d0d218ddec8c1eeb830975fe9c8524a62df4e192724cdff450ad6e33fb5347 miabbott-rhcos:latest
Config commit: v3.1-755-g966e8841e8f9b32586306f7719efe727a3446007
Using manifest: /srv/src/config/manifest.yaml
Copying ostree commit into container: f8d0d218ddec8c1eeb830975fe9c8524a62df4e192724cdff450ad6e33fb5347 ...
+ ostree --repo=/home/builder/.local/share/containers/storage/overlay/6e3e54178ce0d391a0648e00402d8e3a06822dce11f745c088e791743fea8f31/merged/srv/repo pull-local /srv/tmp/repo f8d0d218ddec8c1eeb830975fe9c8524a62df4e192724cdff450ad6e33fb5347
3147 metadata, 20330 content objects imported                                                                                                                                                                        
+ buildah config --entrypoint [\"/noentry\"] -l com.coreos.ostree-commit=f8d0d218ddec8c1eeb830975fe9c8524a62df4e192724cdff450ad6e33fb5347 -l version=44.81.202002052139-0 working-container
Committing container...
Getting image source signatures
Copying blob b8e8ff90fcda done
Copying config 69d4ddd6d6 done
Writing manifest to image destination
Storing signatures
miabbott-rhcos:latest 69d4ddd6d6c9e1ce38c1513ed2781b29d611802457e6a1ae91c66a2cef3e056c
Error: stat /sys/fs/cgroup/systemd/user.slice/user-1000.slice/[email protected]/dbus\x2d:1.2\x2dcom.gexperts.Tilix.slice/dbus-:[email protected]/991546ce550afd3dcbac87f3487ead90e4c91a1417c03b0a055a759ef201b39e: no such file or directory
Traceback (most recent call last):
  File "/usr/lib/coreos-assembler/oscontainer.py", line 287, in <module>
    main()
  File "/usr/lib/coreos-assembler/oscontainer.py", line 283, in main
    authfile=args.authfile)
  File "/usr/lib/coreos-assembler/oscontainer.py", line 214, in oscontainer_build
    inspect = run_get_json(podman_base_argv + ['inspect', image_name_and_tag])[0]
  File "/usr/lib/coreos-assembler/oscontainer.py", line 54, in run_get_json
    return json.loads(subprocess.check_output(args))
  File "/usr/lib64/python3.7/subprocess.py", line 411, in check_output
    **kwargs).stdout
  File "/usr/lib64/python3.7/subprocess.py", line 512, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['podman', 'inspect', 'miabbott-rhcos:latest']' returned non-zero exit status 125.
ERRO exit status 1                                
ERRO exit status 1                                                            

The image was created, but it looks like podman is probing the wrong namespace?

$ ls -l /home/builder/.local/share/containers/storage/overlay-images/
total 12
drwx------. 2 builder builder 4096 Feb  7 15:17 69d4ddd6d6c9e1ce38c1513ed2781b29d611802457e6a1ae91c66a2cef3e056c
-rw-------. 1 builder builder 1592 Feb  7 15:17 images.json
-rw-------. 1 builder builder   64 Feb  7 15:17 images.lock
[coreos-assembler]$ jq '.[]["names"]' < /home/builder/.local/share/containers/storage/overlay-images/images.json 
[
  "localhost/miabbott-rhcos:latest"
]

It's further along than when I tried this recently, so still an improvement!

[jlebon]

It's kind of confusing the relationship between oscontainer and upload-oscontainer. Seems like we should just fold this into oscontainer? IOW, teach cmd-oscontainer about cosa metadata and just let it inject into meta.json?

Anyway, not opposed to doing that as a follow-up!

[cgwalters]

OK rebased 🏄 and did an additional tweak to automatically copy in ~/.docker/config.json which makes this work out of the box in a dev container.

[jlebon]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cgwalters,jlebon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment