refactor fedora message sending into cosalib/fedora_messaging_request.py #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
so I got this to work for sending a message to staging but it never responded. I'll have to investigate if staging robosig is in a good state or not. |
darkmuggle
reviewed
Feb 5, 2020
cgwalters
approved these changes
Feb 5, 2020
|
ok I pushed up an update:
|
|
also figured out the issue with staging and successfully sent a request and got a response |
jlebon
reviewed
Feb 5, 2020
This commit re-factors out the code that sends requests to fedora releng/infra via fedora messaging messages into a library. It can then be called by the code in src/cmd-sign as well as new consumers in the future.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, dustymabe, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
arithx
pushed a commit
to arithx/coreos-assembler
that referenced
this pull request
Feb 7, 2020
```
Benjamin Gilbert (3):
cmd/ore/aws: let list-regions list disabled regions, or all regions
Merge pull request coreos#1102 from bgilbert/regions
Merge pull request coreos#1104 from jcajka/bcrypt
Jakub Čajka (1):
kola/tests/rpmostree: use NVR instead of NVRA
Jonathan Lebon (5):
auth/aliyun: fix parsing config file
Merge pull request coreos#1105 from jlebon/pr/aliyun-profile-fix
ore/aliyun: add --delete-object and default to true
platform/api/aliyun: sprinkle with some logging
Merge pull request coreos#1107 from jlebon/pr/aliyun-delete-object
```
jcajka
pushed a commit
to jcajka/coreos-assembler
that referenced
this pull request
Mar 24, 2020
cmd/ore/aws: let list-regions list disabled regions, or all regions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-factors out the code that sends requests to fedora
releng/infra via fedora messaging messages into a library. It can
then be called by the code in src/cmd-sign as well as new consumers
in the future.
Also implements request_id for fedmsg passing in cmd-sign.