oscontainer: Add support for --display-name #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And if present, inject the OpenShift labels for `machine-os`. Currently this is inlined for OKD (FCOS) in https://github.com/openshift/release/blob/27a5d056b53aba5818795c2ee03d053f754d75da/ci-operator/jobs/openshift/release/openshift-release-release-4.4-periodics.yaml#L533 This will be used for RHCOS to have its version appear in the release image. xref openshift/oc#209 (comment)
darkmuggle
approved these changes
Feb 5, 2020
|
/lgtm |
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, darkmuggle, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
arithx
pushed a commit
to arithx/coreos-assembler
that referenced
this pull request
Feb 7, 2020
```
Benjamin Gilbert (3):
cmd/ore/aws: let list-regions list disabled regions, or all regions
Merge pull request coreos#1102 from bgilbert/regions
Merge pull request coreos#1104 from jcajka/bcrypt
Jakub Čajka (1):
kola/tests/rpmostree: use NVR instead of NVRA
Jonathan Lebon (5):
auth/aliyun: fix parsing config file
Merge pull request coreos#1105 from jlebon/pr/aliyun-profile-fix
ore/aliyun: add --delete-object and default to true
platform/api/aliyun: sprinkle with some logging
Merge pull request coreos#1107 from jlebon/pr/aliyun-delete-object
```
jcajka
pushed a commit
to jcajka/coreos-assembler
that referenced
this pull request
Mar 24, 2020
kola/tests/rpmostree: use NVR instead of NVRA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And if present, inject the OpenShift labels for
machine-os.Currently this is inlined for OKD (FCOS) in
https://github.com/openshift/release/blob/27a5d056b53aba5818795c2ee03d053f754d75da/ci-operator/jobs/openshift/release/openshift-release-release-4.4-periodics.yaml#L533
This will be used for RHCOS to have its version appear in the
release image.
xref openshift/oc#209 (comment)