Fix bindings prune containers flaky test

[jmguzik]

In #9863 prune containers filter params were narrowed to support only those
required by http API. name filter in bindings was replaced by until filter,
which is not a good match, as until filters are causing tests to be flaky.

Signed-off-by: Jakub Guzik [email protected]

[jmguzik]

@rhatdan FYI

[rhatdan]

That works, but I would love to get a working tests in.
LGTM to fix flakes for now.
@containers/podman-maintainers PTAL
/approve

[vrothberg]

I prefer to use Skip(...) and not remove the code, so we leave some breadcrumbs for the future.

Can you elaborate on what is causing the flakes? (would be great in the commit message and a comment in the test)

[jmguzik]

@rhatdan @vrothberg The problem is in bindings every test is instantiated with default container:

_, err := bt.RunTopContainer(&name, nil)

This excludes using label as a filter in this test. I maybe lack experience, but saw that adding label is not that easy and possibly not worthy, as it is tested in apiv2 tests.

I tried a second filter allowed which is until, but it causes tests to flake. In my opinion, it is related to the time conversions which are occurring in the API (one format to another) and accuracy. If you include sleep in this test, it should pass.

So, it is impossible to recreate previous test behavior (which was wrong, because filters from the list were used here) as the only filter that can be used is a label (or until with sleep if you want). Thus, in my opinion, skip is not valid here. You would skip invalid behavior.

[jmguzik]

And unitil is added by me, previously name filter was here.

[vrothberg]

@edsantiago may have an idea how to make it pass

[jmguzik]

@vrothberg my alternative idea for sleep until would be something like 0ns or 1ns and keeping fingers crossed that it is enough.
I would suggest however to remove this one and I can experiment further once @edsantiago will provide input.

[edsantiago]

@vrothberg @jmguzik sorry, this is way above my head. I don't know ginkgo at all.

[jmguzik]

@vrothberg @jmguzik sorry, this is way above my head. I don't know ginkgo at all.

So, then my proposition would be to test with ns or sleep if you really want until check. @vrothberg please let me know what you prefer.

[rhatdan]

/approve
/lgtm
Lets work on this in a separate PR. For now I want to fixup CI so tests can merge.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmguzik, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment