Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate until container prune tests for bindings #9912

Conversation

jmguzik
Copy link
Contributor

@jmguzik jmguzik commented Apr 1, 2021

#9902 follow-up.
/kind bug
Please double-check that, but it seems until filter was wrongly implemented.

Docker API https://docs.docker.com/engine/api/v1.41/#operation/ContainerPrune states:

until=<timestamp> Prune containers created before this timestamp. 
The <timestamp> can be Unix timestamps, date formatted
timestamps, or Go duration strings (e.g. 10m, 1h30m) computed 
relative to the daemon machine’s time.

More or less the same can be found in podman API. In the code, after was used instead of until. That caused tests to flake heavily.
If you approve the code change, I will look for similar errors, because until is probably badly implemented in other places.

Added also test for list containers with until filter. Dates are now set as Unix timestamp way in future and in past, so tests should not flake.

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 1, 2021
@jmguzik jmguzik force-pushed the recreate-prune-until-tests-for-containers branch from b6d7994 to 370a7d7 Compare April 1, 2021 09:22
@jmguzik
Copy link
Contributor Author

jmguzik commented Apr 1, 2021

/cc @rhatdan

@jmguzik jmguzik force-pushed the recreate-prune-until-tests-for-containers branch from 370a7d7 to 231b875 Compare April 1, 2021 09:30
@jmguzik jmguzik force-pushed the recreate-prune-until-tests-for-containers branch from 231b875 to c5beaf0 Compare April 1, 2021 10:10
@mheon
Copy link
Member

mheon commented Apr 1, 2021 via email

@rhatdan
Copy link
Member

rhatdan commented Apr 2, 2021

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmguzik, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2021
@openshift-merge-robot openshift-merge-robot merged commit 1db9053 into containers:master Apr 2, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants