Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing podman-remote build options #9884

Merged
merged 1 commit into from
Apr 3, 2021
Merged

Fix missing podman-remote build options #9884

merged 1 commit into from
Apr 3, 2021

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Mar 30, 2021 •
edited
Loading

Fix handling of SecurityOpts
LabelOpts
SeccompProfilePath
ApparmorProfile

Fix Ulimits

Fixes: #9869

Signed-off-by: Daniel J Walsh [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2021
@edsantiago
Copy link
Member

edsantiago commented Mar 30, 2021 •
edited
Loading

--target is referenced in only one buildah test:
https://github.com/containers/buildah/blob/f2ef995e8a42d6609ae25ecf90c17281798f39b9/tests/bud.bats#L1525-L1537

vrothberg
vrothberg reviewed Mar 30, 2021
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but note that none of the compat-related code seems to be executed in tests at the moment. Do we have something planned to exercise the compat build endpoint?

@rhatdan
Copy link
Member Author

rhatdan commented Mar 30, 2021 •
edited
Loading

@edsantiago you were right, I have now hooked up --target as well. I had misunderstood the code.

@rhatdan
Copy link
Member Author

rhatdan commented Mar 30, 2021

--target=stageName
Set the target build stage to build. When building a Containerfile with multiple build stages, --target can be used to specify an intermediate build stage by name as the final stage for the resulting image. Commands after the target stage will be skipped.

TomSweeneyRedHat
TomSweeneyRedHat reviewed Mar 30, 2021
View reviewed changes
pkg/api/handlers/compat/images_build.go Outdated
DNSSearch: dnssearch,
HTTPProxy: query.HTTPProxy,
LabelOpts: labelOpts,
SeccompProfilePath: seccomp,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make my OCD, happy, can you move this down a bit in alpha order, please.

@mheon
Copy link
Member

mheon commented Mar 31, 2021

Restarting bindings test - I think the failure might be a flake?

@edsantiago
Copy link
Member

Bindings flake is (was) #9902

@TomSweeneyRedHat
Copy link
Member

@rhatdan can you rebase and see if 9902 fixes this?

@rhatdan
Fix missing podman-remote build options
0527328 
Fix handling of SecurityOpts
   LabelOpts
   SeccompProfilePath
   ApparmorProfile

Fix Ulimits

Fixes: containers#9869

Signed-off-by: Daniel J Walsh <[email protected]>
@rhatdan
Copy link
Member Author

rhatdan commented Apr 3, 2021

@containers/podman-maintainers PTAL
This is ready to merge.

@mheon
Copy link
Member

mheon commented Apr 3, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2021
@openshift-merge-robot openshift-merge-robot merged commit 3070141 into containers:master Apr 3, 2021
@edsantiago edsantiago mentioned this pull request Apr 7, 2021
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

@vrothberg vrothberg vrothberg left review comments

Assignees

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

podman-remote build: --rm=false is ignored
7 participants
@rhatdan @openshift-ci-robot @edsantiago @mheon @TomSweeneyRedHat @vrothberg @openshift-merge-robot