-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHEL gating tests: more journald exceptions #8714
RHEL gating tests: more journald exceptions #8714
Conversation
Followup to containers#8284, due to my not having noticed containers#8096. RHEL gating tests are failing again due to rhbz#1895105, the one where we can't run journalctl rootless on RHEL. containers#8284 fixed this for some RHEL builds of older podman, but I missed containers#8096 which added yet another logs test. This brings us to three journalctl exceptions, which means it gets complicated because I have to refactor it all. **THIS IS NOT SUSTAINABLE**. We need some way to have a similar setup in CI, with a permission-less rootless login, so we don't add yet another logs test some day and discover, months later, that it doesn't work on RHEL and then have to go into crisis mode. Signed-off-by: Ed Santiago <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jnovy FYI |
LGTM |
@containers/podman-maintainers PTAL. Suggestions welcome on how we can catch this sort of problem earlier. I tested the new code on a RHEL VM, and the journal tests are indeed skipped when run rootless. |
LGTM |
/lgtm |
Would podman-in-a-container catch the journald case? We wouldn't have access to the host systemd, so I presume journald would blow up. |
Hmmm. Looks like we lost @mheon I'm not sure how to test, but my gut feel is that P-in-P would not catch this: the symptom we're looking for is: $ journalctl -n 1
Hint: You are currently not seeing messages from other users and the system.
Users in the 'systemd-journal' group can see all messages. Pass -q to
turn off this notice.
No journal files were opened due to insufficient permissions. This happens when |
It's there, just has a new name, |
containers#8714 (comment) Signed-off-by: Chris Evich <[email protected]>
Followup to #8284, due to my not having noticed #8096.
RHEL gating tests are failing again due to rhbz#1895105, the
one where we can't run journalctl rootless on RHEL. #8284 fixed
this for some RHEL builds of older podman, but I missed #8096
which added yet another logs test.
This brings us to three journalctl exceptions, which means
it gets complicated because I have to refactor it all.
THIS IS NOT SUSTAINABLE. We need some way to have a similar
setup in CI, with a permission-less rootless login, so we don't
add yet another logs test some day and discover, months later,
that it doesn't work on RHEL and then have to go into crisis
mode.
Signed-off-by: Ed Santiago [email protected]