Tests: Check different log driver can work with podman logs #8096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhatdan
approved these changes
Oct 21, 2020
test/system/030-run.bats
Outdated
| @@ -413,6 +413,16 @@ json-file | f | |||
| else | |||
| is "$output" "" "LogPath (driver=$driver)" | |||
| fi | |||
|
|
|||
| run_podman ? logs myctr | |||
There was a problem hiding this comment.
Thanks for reminder. Updated.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, ypu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
test/system/030-run.bats
Outdated
|
|
||
| run_podman ? logs myctr | ||
| if [[ $driver != 'none' ]]; then | ||
| is "$output" "$msg" "check that podman logs works as expect" |
There was a problem hiding this comment.
nit, only if you need to make other changes:
Suggested change
| is "$output" "$msg" "check that podman logs works as expect" | |
| is "$output" "$msg" "check that podman logs works as expected" |
edsantiago
reviewed
Oct 21, 2020
test/system/030-run.bats
Outdated
| run_podman ? logs myctr | ||
| if [[ $driver != 'none' ]]; then | ||
| is "$output" "$msg" "check that podman logs works as expect" | ||
| [[ $status == 0 ]] |
There was a problem hiding this comment.
The bats [[ usage is evil. Please do this instead:
if [[ $driver == 'none' ]]; then
run_podman 125 logs myctr
...
else
run_podman logs myctr
...
fiAdd a check step in podman run --log-driver test. Prefer to add it here as it already has a loop to cover all different drivers in this test. Signed-off-by: Yiqiao Pu <[email protected]>
|
Thanks @TomSweeneyRedHat and @edsantiago for your comments. Update the code, also fixed the check failed for --log-driver none in remote test. |
|
/lgtm Thank you! |
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Dec 14, 2020
Followup to containers#8284, due to my not having noticed containers#8096. RHEL gating tests are failing again due to rhbz#1895105, the one where we can't run journalctl rootless on RHEL. containers#8284 fixed this for some RHEL builds of older podman, but I missed containers#8096 which added yet another logs test. This brings us to three journalctl exceptions, which means it gets complicated because I have to refactor it all. **THIS IS NOT SUSTAINABLE**. We need some way to have a similar setup in CI, with a permission-less rootless login, so we don't add yet another logs test some day and discover, months later, that it doesn't work on RHEL and then have to go into crisis mode. Signed-off-by: Ed Santiago <[email protected]>
pmoogi-redhat
pushed a commit
to pmoogi-redhat/podman
that referenced
this pull request
Dec 15, 2020
Followup to containers#8284, due to my not having noticed containers#8096. RHEL gating tests are failing again due to rhbz#1895105, the one where we can't run journalctl rootless on RHEL. containers#8284 fixed this for some RHEL builds of older podman, but I missed containers#8096 which added yet another logs test. This brings us to three journalctl exceptions, which means it gets complicated because I have to refactor it all. **THIS IS NOT SUSTAINABLE**. We need some way to have a similar setup in CI, with a permission-less rootless login, so we don't add yet another logs test some day and discover, months later, that it doesn't work on RHEL and then have to go into crisis mode. Signed-off-by: Ed Santiago <[email protected]>
mheon
pushed a commit
to mheon/libpod
that referenced
this pull request
Jan 5, 2021
Followup to containers#8284, due to my not having noticed containers#8096. RHEL gating tests are failing again due to rhbz#1895105, the one where we can't run journalctl rootless on RHEL. containers#8284 fixed this for some RHEL builds of older podman, but I missed containers#8096 which added yet another logs test. This brings us to three journalctl exceptions, which means it gets complicated because I have to refactor it all. **THIS IS NOT SUSTAINABLE**. We need some way to have a similar setup in CI, with a permission-less rootless login, so we don't add yet another logs test some day and discover, months later, that it doesn't work on RHEL and then have to go into crisis mode. Signed-off-by: Ed Santiago <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check step in podman run --log-driver test. Prefer to add it here as it already has a loop to cover all different drivers
in this test.