system tests: skip journald tests on RHEL8 #8284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
(actually, on any system exhibiting the symptom wherein journalctl fails due to insufficient permissions, which for all practical purposes means only RHEL8) Signed-off-by: Ed Santiago <[email protected]>
|
Tested by applying patch to podman-tests-2.1.1-3.module+el8.3.1+8686+2a59bca3.x86_64 on RHEL8. Results: $ bats /usr/share/podman/test/system/03*bats
- podman run --log-driver journald (skipped: Cannot use rootless journald on this system)
...
- podman logs over journald (skipped: Cannot use rootless journald on this system)After adding testuser to ✓ podman run --log-driver journald
...
✓ podman logs over journald(i.e. they now run and pass). |
|
LGTM, I have a feeling centos8 will not work well without this patch either. |
| skip "Cannot use rootless journald on this system" | ||
| fi | ||
| fi | ||
| fi |
There was a problem hiding this comment.
Would it be good to move this to a skip_if_rootless_rhel type of function?
There was a problem hiding this comment.
Sorry for the too-late response. As much as I hate duplication, on two-offs I often just hold my nose and leave it. Should there ever be a need for a third exception, then yes, absolutely, refactor.
|
Changes LGTM, one question for consideration. |
|
/lgtm |
|
We need to get this into RHEL8. Do I need to backport it into a maint branch, or will RHEL8 pick up a new build from here? @jnovy? |
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Dec 14, 2020
Followup to containers#8284, due to my not having noticed containers#8096. RHEL gating tests are failing again due to rhbz#1895105, the one where we can't run journalctl rootless on RHEL. containers#8284 fixed this for some RHEL builds of older podman, but I missed containers#8096 which added yet another logs test. This brings us to three journalctl exceptions, which means it gets complicated because I have to refactor it all. **THIS IS NOT SUSTAINABLE**. We need some way to have a similar setup in CI, with a permission-less rootless login, so we don't add yet another logs test some day and discover, months later, that it doesn't work on RHEL and then have to go into crisis mode. Signed-off-by: Ed Santiago <[email protected]>
pmoogi-redhat
pushed a commit
to pmoogi-redhat/podman
that referenced
this pull request
Dec 15, 2020
Followup to containers#8284, due to my not having noticed containers#8096. RHEL gating tests are failing again due to rhbz#1895105, the one where we can't run journalctl rootless on RHEL. containers#8284 fixed this for some RHEL builds of older podman, but I missed containers#8096 which added yet another logs test. This brings us to three journalctl exceptions, which means it gets complicated because I have to refactor it all. **THIS IS NOT SUSTAINABLE**. We need some way to have a similar setup in CI, with a permission-less rootless login, so we don't add yet another logs test some day and discover, months later, that it doesn't work on RHEL and then have to go into crisis mode. Signed-off-by: Ed Santiago <[email protected]>
mheon
pushed a commit
to mheon/libpod
that referenced
this pull request
Jan 5, 2021
Followup to containers#8284, due to my not having noticed containers#8096. RHEL gating tests are failing again due to rhbz#1895105, the one where we can't run journalctl rootless on RHEL. containers#8284 fixed this for some RHEL builds of older podman, but I missed containers#8096 which added yet another logs test. This brings us to three journalctl exceptions, which means it gets complicated because I have to refactor it all. **THIS IS NOT SUSTAINABLE**. We need some way to have a similar setup in CI, with a permission-less rootless login, so we don't add yet another logs test some day and discover, months later, that it doesn't work on RHEL and then have to go into crisis mode. Signed-off-by: Ed Santiago <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(actually, on any system exhibiting the symptom wherein
journalctl --user fails due to insufficient permissions,
which for all practical purposes means only RHEL8)
Signed-off-by: Ed Santiago [email protected]