Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cirrus: Restore APIv2 Testing #7967

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Cirrus: Restore APIv2 Testing #7967

merged 1 commit into from
Oct 13, 2020

Conversation

cevich
Copy link
Member

@cevich cevich commented Oct 8, 2020

Fixes #7954

This was mistakenly left out of 2c9084e

Signed-off-by: Chris Evich [email protected]

@cevich cevich requested review from edsantiago and baude October 8, 2020 16:59
@cevich cevich force-pushed the restore_apiv2_test branch 4 times, most recently from 30f9942 to 5100736 Compare October 8, 2020 17:28
@rhatdan
Copy link
Member

rhatdan commented Oct 8, 2020

@baude PTAL

@cevich cevich force-pushed the restore_apiv2_test branch 3 times, most recently from 264b6b7 to 40c7ebc Compare October 8, 2020 20:10
@rhatdan
Copy link
Member

rhatdan commented Oct 8, 2020

How come this
APIv2 test on fedora-32

Does not have a green check mark?

@cevich cevich mentioned this pull request Oct 8, 2020
Closed
@cevich
Copy link
Member Author

cevich commented Oct 8, 2020

Does not have a green check mark?

Oh thanks for reminding me. I marked it 'ignore failure', since some of the test items are not working and I need to open an issue on it...

@cevich
Copy link
Member Author

cevich commented Oct 8, 2020

@baude PTAL and would you mind taking/assigning #7972?

@rhatdan
Copy link
Member

rhatdan commented Oct 9, 2020

So we have a checking and the egg situation on this PR. If we merge this PR we will need another PR to turn enforcing mode on.
I wish the Skip if failed was a little more visual that the tests actually failed.
If these tests succeed do they get a check mark? IE Does the grey square box indicated a failed, ignored check?

@cevich
Copy link
Member Author

cevich commented Oct 9, 2020

So we have a checking and the egg situation on this PR.

Aye, hence the issue 😞

If these tests succeed do they get a check mark?

Hmmm, I would only be guessing. I believe the effect of that option is for Cirrus to NOT report any value back, so I think it remains a gray-square no matter what.

@rhatdan one idea could be...just leave this PR sit here until the tests are fixed, and/or rebasing it into the fixing PR.

@cevich
Copy link
Member Author

cevich commented Oct 9, 2020

Note: I added a separate commit which makes the test ignore failures. So once they're green, that commit can just be reverted.

@rhatdan
Copy link
Member

rhatdan commented Oct 10, 2020

@baude @mheon Most of the breakage here is in the Network Stack

@edsantiago
Copy link
Member

@cevich try rebasing on #7994

@edsantiago edsantiago mentioned this pull request Oct 12, 2020
Merged
edsantiago added a commit to edsantiago/libpod that referenced this pull request Oct 12, 2020
@edsantiago
System tests: run with local podman, not remote
7c351fb 
Initially filed as containers#7967 but that has run into huge complicated
snags related to Ubuntu and environment.

It is crucial to get system tests working with podman-local.
It is less important to get them on Ubuntu. Let's please
expedite this PR while we settle the Ubuntu stuff in containers#7967

Signed-off-by: Ed Santiago <[email protected]>
@edsantiago edsantiago mentioned this pull request Oct 12, 2020
Merged
@cevich
Copy link
Member Author

cevich commented Oct 12, 2020

Sure, happy to...

@cevich cevich force-pushed the restore_apiv2_test branch from 40c7ebc to 45d485d Compare October 12, 2020 18:04
@edsantiago
Copy link
Member

My bad; I tested only rootless on my laptop, not root. #8000 should fix.

@edsantiago
Copy link
Member

@cevich third time's the charm? Please rebase at your convenience, let's see if #8000 can get tests passing.

@cevich cevich force-pushed the restore_apiv2_test branch from 45d485d to c3336dd Compare October 13, 2020 13:44
@cevich
Copy link
Member Author

cevich commented Oct 13, 2020

rebased.

@cevich
Copy link
Member Author

cevich commented Oct 13, 2020

@edsantiago in case you didn't realize: It works the other way too, you can temporarily rebase the "fix" pr ontop of this one. You can make the temporary test even faster by marking irreverent tasks with skip: $CI == $CI in .cirrus.yml

@edsantiago
Copy link
Member

I think you accidentally rebased on an old master, can you try current master?

@cevich
Copy link
Member Author

cevich commented Oct 13, 2020

I think you accidentally rebased on an old master, can you try current master?

git says everything up to date...maybe my clone or config is messed up...

@cevich cevich force-pushed the restore_apiv2_test branch from c3336dd to 23087f7 Compare October 13, 2020 15:42
@cevich
Copy link
Member Author

cevich commented Oct 13, 2020

...oof, git config is messed up.

@edsantiago
Copy link
Member

Failure in int remote ubuntu-20 root host was a CI timeout; restarted

@cevich
Copy link
Member Author

cevich commented Oct 13, 2020

Ugg, Failed in 01:30:50...these remote tasks are running awful close to the line. I know some folks have a mind to make these tests run quicker. If we keep seeing this, it's probably worth bumping up the timeout by another 10-20 minutes 😞

@edsantiago
Copy link
Member

AFAIK nobody has even the slightest intention of making anything run quicker. If anything, it's the opposite. So, yeah, bumping the timeout might be necessary.

@cevich
Copy link
Member Author

cevich commented Oct 13, 2020

AFAIK nobody has even the slightest intention of making anything run quicker.

@baude spoke last week or the one before about speeding them up. IIRC was something about moving calls from PodmanNoCache() -> Podman(), eh? I tried to look if there's a card for this...but jira is not behaving ATM 😞

@mheon
Copy link
Member

mheon commented Oct 13, 2020

I think looking into speeding up the remote tests specifically is worth it, if only to improve turnaround time from PR creation -> test success - 90 minutes is getting absurd for small changes. Makes my life on release day absolutely miserable.

@cevich
Copy link
Member Author

cevich commented Oct 13, 2020

@mheon @baude confirmed, I don't see any jira card for this activity. Mind creating one, so the wish is retained in writing? 😄

@edsantiago
Copy link
Member

/lgtm
/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 13, 2020
@openshift-merge-robot openshift-merge-robot merged commit 98708b1 into containers:master Oct 13, 2020
@edsantiago edsantiago mentioned this pull request Oct 19, 2020
Closed
@cevich cevich deleted the restore_apiv2_test branch June 30, 2021 18:00
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edsantiago edsantiago Awaiting requested review from edsantiago

@baude baude Awaiting requested review from baude

Assignees

@edsantiago edsantiago

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: looks like we lost test-apiv2
6 participants
@cevich @rhatdan @edsantiago @mheon @openshift-ci-robot @openshift-merge-robot