APIv2 tests: try again to fix them #8000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
mheon
reviewed
Oct 12, 2020
test/apiv2/01-basic.at
Outdated
| @@ -68,7 +68,7 @@ for i in $(seq 1 10); do | |||
| done | |||
| t1=$SECONDS | |||
| delta_t=$((t1 - t2)) | |||
| if [ $delta_t -le 5 ]; then | |||
| if [ $delta_t -le 7 ]; then | |||
| _show_ok 1 "Time for ten /info requests ($delta_t seconds) <= 5s" | |||
There was a problem hiding this comment.
Argh. That's exactly why I hate duplication. Fixed, and refactored so it shouldn't happen again the next time we have to bump up the time limit. Thank you for catching that.
CI discovered that a lot of networking tests are failing; my fault, for not having run my tests as root on my laptop. Disable those. Also: bump up the ten-request time limit, from 5 to 7 seconds. Looks like something keeps getting slower and slower, but I guess there's not much we can do about it. Also: when we get a mismatch response code (e.g. 500 when we expect 200), dump the response body and skip any subsequent response checks. Signed-off-by: Ed Santiago <[email protected]>
edsantiago
force-pushed
the
fix_apiv2_tests_again
branch
from
9f326f0 to
2a6a3f3
Compare
|
Cirrus flake again, |
|
Yet another |
|
LGTM |
|
/lgtm |
This was referenced Oct 19, 2020
Closed
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI discovered that a lot of networking tests are failing; my
fault, for not having run my tests as root on my laptop.
Disable those.
Also: bump up the ten-request time limit, from 5 to 7 seconds.
Looks like something keeps getting slower and slower, but I
guess there's not much we can do about it.
Also: when we get a mismatch response code (e.g. 500 when we
expect 200), dump the response body and skip any subsequent
response checks.
Signed-off-by: Ed Santiago [email protected]