Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System tests: run with local podman, not remote #7996

Merged
merged 1 commit into from
Oct 13, 2020
Merged

System tests: run with local podman, not remote #7996

merged 1 commit into from
Oct 13, 2020

Conversation

edsantiago
Copy link
Member

Initially filed as #7967 but that has run into huge complicated
snags related to Ubuntu and environment.

It is crucial to get system tests working with podman-local.
It is less important to get them on Ubuntu. Let's please
expedite this PR while we settle the Ubuntu stuff in #7967

Signed-off-by: Ed Santiago [email protected]

@edsantiago
System tests: run with local podman, not remote
7c351fb 
Initially filed as containers#7967 but that has run into huge complicated
snags related to Ubuntu and environment.

It is crucial to get system tests working with podman-local.
It is less important to get them on Ubuntu. Let's please
expedite this PR while we settle the Ubuntu stuff in containers#7967

Signed-off-by: Ed Santiago <[email protected]>
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2020
@edsantiago
Copy link
Member Author

From an initial glance it looks like this change is successful: I see sys podman fedora-3[12] rootless host (prior to this PR, the test names would be "sys remote fedora etc"). Once tests are finished I will confirm by looking at test logs.

@edsantiago
Copy link
Member Author

The dreaded "CI agent stopped responding!" flake. Restarted.

@edsantiago
Copy link
Member Author

Tests are green. I've confirmed that the sys podman fedora-32 rootless host test is indeed running local-podman (if it were remote, the "logs multi" test would've been skipped).

@containers/podman-maintainers PTAL and let's try to merge this soon so we can prevent breakage in rootless system tests.

@mheon
Copy link
Member

mheon commented Oct 12, 2020

LGTM

@edsantiago edsantiago mentioned this pull request Oct 12, 2020
Closed
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vrothberg
vrothberg reviewed Oct 13, 2020
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2020
@openshift-merge-robot openshift-merge-robot merged commit b1b9d9e into containers:master Oct 13, 2020
@edsantiago edsantiago deleted the ci_systemtest_rootless_safe branch October 13, 2020 11:15
@edsantiago edsantiago mentioned this pull request Oct 19, 2020
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

Assignees

@vrothberg vrothberg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@edsantiago @mheon @openshift-ci-robot @vrothberg @saschagrunert @openshift-merge-robot