-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
system tests: new tests for run, exec #6958
Conversation
LGTM |
15fbbc7
to
bd89e7f
Compare
- Issue containers#6735 : problem with multiple namespaces; confirms combinations of --userns=keep-id, --privileged, --user=XX - Issue containers#6829 : --userns=keep-id will add a /etc/passwd entry - Issue containers#6593 : podman exec, with --userns=keep-id, errors (test is currently skipped because issue remains live) ...and, addendum: add new helper function, remove_same_dev_warning. Some CI systems issue a warning on podman run --privileged: WARNING: The same type, major and minor should not be used for multiple devices. We already had special-case code to ignore than in the SELinux test, but now we're seeing it in the new run tests I added, so I've refactored the "ignore this warning" code and written tests for the removal code. Signed-off-by: Ed Santiago <[email protected]>
Tests are finally green after a lot of flakes, many of them new and disturbing. EDIT: results of cirrus-flake-summarize below. The apiv2 flake is addressed by #6978. The 'podman search with wildcards' were all permission denied:
...and all happened near the same time, so it may have been a problem on the registry itself. The in-podman fedora-31 fedora-312020-07-14T15:02:43 integration_test
special_testing_rootless fedora-322020-07-14T14:55:23 integration_test
test fedora-31 fedora-312020-07-14T15:04:15 integration_test
test fedora-32 fedora-322020-07-14T15:04:39 integration_test
test ubuntu-19 ubuntu-192020-07-14T15:03:14 integration_test
2020-07-14T15:52:55 apiv2_test
|
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue Invoking mount in privileged rootless container fails due to privileges #6735 : problem with multiple namespaces; confirms
combinations of --userns=keep-id, --privileged, --user=XX
Issue Add username to /etc/passwd inside of container if --userns keep-id #6829 : --userns=keep-id will add a /etc/passwd entry
Issue Json output of podman images not affected by sorting options #6593 : podman exec, with --userns=keep-id, errors
(test is currently skipped because issue remains live)
Signed-off-by: Ed Santiago [email protected]