Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system tests: new tests for run, exec #6958

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

edsantiago
Copy link
Member

Signed-off-by: Ed Santiago [email protected]

@rhatdan
Copy link
Member

rhatdan commented Jul 13, 2020

LGTM

@edsantiago edsantiago force-pushed the bats branch 2 times, most recently from 15fbbc7 to bd89e7f Compare July 14, 2020 19:27
 - Issue containers#6735 : problem with multiple namespaces; confirms
   combinations of --userns=keep-id, --privileged, --user=XX

 - Issue containers#6829 : --userns=keep-id will add a /etc/passwd entry

 - Issue containers#6593 : podman exec, with --userns=keep-id, errors
   (test is currently skipped because issue remains live)

...and, addendum: add new helper function, remove_same_dev_warning.
Some CI systems issue a warning on podman run --privileged:

   WARNING: The same type, major and minor should not be used for multiple devices.

We already had special-case code to ignore than in the SELinux
test, but now we're seeing it in the new run tests I added, so
I've refactored the "ignore this warning" code and written
tests for the removal code.

Signed-off-by: Ed Santiago <[email protected]>
@edsantiago
Copy link
Member Author

edsantiago commented Jul 14, 2020

Tests are finally green after a lot of flakes, many of them new and disturbing.

EDIT: results of cirrus-flake-summarize below. The apiv2 flake is addressed by #6978. The 'podman search with wildcards' were all permission denied:

error searching registry \"registry.redhat.io\": couldn't search registry \"registry.redhat.io\": unable to retrieve auth token: invalid username/password: unauthorized: Please login to the Red Hat Registry using your Customer Portal credentials. Further instructions can be found here: https://access.redhat.com/RegistryAuthentication

...and all happened near the same time, so it may have been a problem on the registry itself. The --preserve-fds one bothers me. It looks awfully similar to #5769.

in-podman fedora-31 fedora-31

2020-07-14T15:02:43 integration_test

  • Podman run networking [It] podman run network expose duplicate host port results in error
  • Podman search [It] podman search with wildcards
  • [same]
  • [same]

special_testing_rootless fedora-32

2020-07-14T14:55:23 integration_test

  • Podman search [It] podman search with wildcards
  • [same]
  • [same]

test fedora-31 fedora-31

2020-07-14T15:04:15 integration_test

  • Podman run networking [It] podman run network expose duplicate host port results in error
  • Podman run [It] podman run --preserve-fds
  • [same]
  • [same]
  • Podman pod restart [It] podman pod restart single pod by name

test fedora-32 fedora-32

2020-07-14T15:04:39 integration_test

  • Podman rmi [It] podman rmi with cached images
  • [same]
  • Podman search [It] podman search with wildcards
  • [same]
  • [same]
  • Podman pod rm [It] podman pod start/remove single pod via --pod-id-file
  • Podman pod rm [It] podman pod start/remove multiple pods via --pod-id-file

test ubuntu-19 ubuntu-19

2020-07-14T15:03:14 integration_test

  • Podman run [It] podman run --mount type=bind,bind-nonrecursive
  • Podman search [It] podman search with wildcards
  • [same]
  • [same]

2020-07-14T15:52:55 apiv2_test

  • 142 [20-containers] DELETE libpod/containers/7e870fc3e09b2e501c8eb330f2a0c56292920aff04d5c561caf62603443be22a : status
  • 143 [20-containers] DELETE libpod/containers/7e870fc3e09b2e501c8eb330f2a0c56292920aff04d5c561caf62603443be22a: 204 status returns no output

@rhatdan
Copy link
Member

rhatdan commented Jul 15, 2020

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2020
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, giuseppe, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8704b78 into containers:master Jul 15, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants