Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI flake: run --preserve-fds: attach / unixpacket / bad file descriptor #6987

Closed
edsantiago opened this issue Jul 15, 2020 · 4 comments
Closed

CI flake: run --preserve-fds: attach / unixpacket / bad file descriptor #6987

edsantiago opened this issue Jul 15, 2020 · 4 comments
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. stale-issue

Comments

@edsantiago
Copy link
Member

Flake seen three times on CI for #6958. Passed on re-run:

Running: podman [options] run --preserve-fds 1 docker.io/library/alpine:latest ls
time="2020-07-14T16:51:22-04:00" level=error msg="unable to close socket: \"close unixpacket @->/tmp/podman_test328676400/socket/7d5388edb2bed82a1bfbd8d549e58fa977154dfd03c5f6dc4ceadac06597f15c/attach: bad file descriptor\""
Error: error attaching to container 7d5388edb2bed82a1bfbd8d549e58fa977154dfd03c5f6dc4ceadac06597f15c: read unixpacket @->/tmp/podman_test328676400/socket/7d5388edb2bed82a1bfbd8d549e58fa977154dfd03c5f6dc4ceadac06597f15c/attach: read: bad file descriptor

Log: https://api.cirrus-ci.com/v1/task/6481256420474880/logs/integration_test.log#t--podman-run---preserve-fds

This was in "test fedora-31". cirrus-flake-xref finds no other instances of this in the last three weeks.

The error looks suspiciously close to #5769 (fixed last month), but that was exec; this is run. Possibly because of #6625
@edsantiago
Copy link
Member Author

@QiWang19 PTAL

@edsantiago edsantiago changed the title CI flake: attach / unixpacket / bad file descriptor CI flake: run --preserve-fds: attach / unixpacket / bad file descriptor Jul 15, 2020
@edsantiago
Copy link
Member Author

Seeing it on f32 now. Three failures, so it caused a CI flake. @QiWang19 PTAL.

@QiWang19 QiWang19 mentioned this issue Jul 28, 2020
Merged
QiWang19 added a commit to QiWang19/podman that referenced this issue Jul 30, 2020
@QiWang19
fix close fds of run --preserve-fds
5796741 
Test flakes mentioned in containers#6987 might be caused by uncorrect closing of file descriptor.
Fix the code to close file descriptors for podman run since it may close those used by other processes.

Signed-off-by: Qi Wang <[email protected]>
@jlebon jlebon mentioned this issue Aug 5, 2020
Closed
@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@QiWang19
Copy link
Contributor

This flake should be fixed by #7120

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. stale-issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edsantiago @QiWang19