Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More exec --preserve-fds flakes: boltdb, and bad file descriptor #5769

Closed
edsantiago opened this issue Apr 8, 2020 · 1 comment · Fixed by #5771
Closed

More exec --preserve-fds flakes: boltdb, and bad file descriptor #5769

edsantiago opened this issue Apr 8, 2020 · 1 comment · Fixed by #5771
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Member

Two new kinds of flakes in CI, all in the 'podman exec preserve fds sanity check' test:

podman [options] exec --preserve-fds 1 test1 ls
...
time="2020-04-08T14:45:15-04:00" level=error msg="unable to close socket: \"close unixpacket @->/tmp/podman_test358810366/socket/638a99e7f003410c5f5e27a943c9cbfbf76dd9a4fce6adc5521aa38a67823b8f/attach: bad file descriptor\""
Error: read unixpacket @->/tmp/podman_test358810366/socket/638a99e7f003410c5f5e27a943c9cbfbf76dd9a4fce6adc5521aa38a67823b8f/attach: read: bad file descriptor

Source: #5767, 1 instance

Next error:

podman [options] exec --preserve-fds 1 test1 ls
...
2020/04/08 14:45:18 bolt.Close(): funlock error: bad file descriptor
time="2020-04-08T14:45:18-04:00" level=error msg="failed to close libpod db: \"db file close: close /tmp/podman_test054218976/crio/libpod/bolt_state.db: bad file descriptor\""
Error: write /tmp/podman_test054218976/crio/libpod/bolt_state.db: bad file descriptor

Seen this one in #5671 instance 1 and instance 2

Also just seeing it in #5767 instance 1, instance 2

There is clearly something still broken in --preserve-fds

giuseppe added a commit to giuseppe/libpod that referenced this issue Apr 9, 2020
it specifies a fd is passed down but we are not really doing it, and
it triggers the wrong fd to be closed by Podman after the OCI runtime
invocation.

Closes: containers#5769

Signed-off-by: Giuseppe Scrivano <[email protected]>
snj33v pushed a commit to snj33v/libpod that referenced this issue May 31, 2020
it specifies a fd is passed down but we are not really doing it, and
it triggers the wrong fd to be closed by Podman after the OCI runtime
invocation.

Closes: containers#5769

Signed-off-by: Giuseppe Scrivano <[email protected]>
@edsantiago
Copy link
Member Author

I'm seeing a new error that looks a lot like this, except it's in run instead of exec (but with --preserve-fds):

Error: error attaching to container ff1e67ec16aa697a4c217508b579af24dd8bd169bbcd068cf11b402c592f51a9: read unixpacket @->/tmp/podman_test136344526/socket/ff1e67ec16aa697a4c217508b579af24dd8bd169bbcd068cf11b402c592f51a9/attach: read: bad file descriptor

Log: https://api.cirrus-ci.com/v1/task/6481256420474880/logs/integration_test.log#t--podman-run---preserve-fds

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant