Podman V2 birth #5852
Merged
Podman V2 birth #5852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
baude
force-pushed
the
v1prune
branch
2 times, most recently
from
2db6af3 to
0b77734
Compare
|
Yikes, Lets get this in once you can pass limited tests. |
baude
force-pushed
the
v1prune
branch
3 times, most recently
from
9d238d9 to
364dfa6
Compare
| return err | ||
| } | ||
| ``` | ||
| To "wire" in the `manifest` command, edit the file ```$GOPATH/src/github.com/containers/libpod/cmd/podmanV2/main.go``` to add: |
There was a problem hiding this comment.
nit, wouldn't this be
Create the file ```$GOPATH/src/github.com/containers/libpod/cmd/podman/manifests/inspect.go
now?
There was a problem hiding this comment.
but you're so good at them 😃
openshift-ci-robot
removed
the
needs-rebase
openshift-ci-robot
added
needs-rebase
|
LGTM |
cevich
reviewed
Apr 16, 2020
cevich
reviewed
Apr 16, 2020
remote podman v1 and replace with podman v2. Signed-off-by: Brent Baude <[email protected]>
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
LGTM |
This was referenced Apr 16, 2020
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remote podman v1 and replace with podman v2.
Signed-off-by: Brent Baude [email protected]