Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cirrus: Add support for Fedora 32 beta #5737

Merged
merged 2 commits into from
Apr 22, 2020

Conversation

cevich
Copy link
Member

@cevich cevich commented Apr 6, 2020

Signed-off-by: Chris Evich [email protected]

@cevich cevich changed the title Cirrus: Add support for Fedora 32 WIP: Cirrus: Add support for Fedora 32 Apr 6, 2020
@cevich cevich added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 6, 2020
@cevich cevich changed the title WIP: Cirrus: Add support for Fedora 32 WIP: [CI:IMG] Cirrus: Add support for Fedora 32 Apr 6, 2020
@cevich cevich force-pushed the add_f32 branch 5 times, most recently from 6ed921a to 989672a Compare April 7, 2020 14:32
@cevich cevich changed the title WIP: [CI:IMG] Cirrus: Add support for Fedora 32 Cirrus: Add support for Fedora 32 beta Apr 7, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2020
@cevich
Copy link
Member Author

cevich commented Apr 7, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2020
@cevich cevich changed the title Cirrus: Add support for Fedora 32 beta WIP: CI:IMG: Cirrus: Add support for Fedora 32 beta Apr 9, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 9, 2020
@cevich cevich force-pushed the add_f32 branch 4 times, most recently from 03ba8fa to da78208 Compare April 13, 2020 20:40
@cevich cevich changed the title WIP: CI:IMG: Cirrus: Add support for Fedora 32 beta WIP: Cirrus: Add support for Fedora 32 beta Apr 14, 2020
@cevich cevich force-pushed the add_f32 branch 2 times, most recently from a38f302 to 7a519d5 Compare April 14, 2020 15:59
@cevich cevich changed the title WIP: Cirrus: Add support for Fedora 32 beta WIP: CI:IMG: Cirrus: Add support for Fedora 32 beta Apr 14, 2020
@cevich cevich changed the title WIP: CI:IMG: Cirrus: Add support for Fedora 32 beta WIP: [CI:IMG]: Cirrus: Add support for Fedora 32 beta Apr 15, 2020
@cevich cevich changed the title WIP: [CI:IMG]: Cirrus: Add support for Fedora 32 beta Cirrus: Add support for Fedora 32 beta Apr 16, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2020
@cevich cevich changed the title Cirrus: Add support for Fedora 32 beta [OPTIONAL] Cirrus: Add support for Fedora 32 beta Apr 16, 2020
@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #5852) made this pull request unmergeable. Please resolve the merge conflicts.

@cevich cevich changed the title [OPTIONAL] Cirrus: Add support for Fedora 32 beta Cirrus: Add support for Fedora 32 beta Apr 21, 2020
@cevich
Copy link
Member Author

cevich commented Apr 21, 2020

@mheon @baude @edsantiago PTAL I'm thinking maybe while things are haywire, we sneak in this PR also. It drops F30 and and brings us up to F31 + 32 and fixes some runc/crun packaging issues.

My motivation is that this PR is a pre-req. for #5853 which we need for buildah and bringing some sanity to our Dockerfile setup. When F32 proper is released, switching from the beta should be relatively painless.

@edsantiago
Copy link
Member

LGTM at first pass

@edsantiago
Copy link
Member

/lgtm

feel free to remove the hold when you think it's ready. (Also needs /approve, which I can't grant)

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2020
@rhatdan
Copy link
Member

rhatdan commented Apr 21, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2020
@rhatdan
Copy link
Member

rhatdan commented Apr 22, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2020
@openshift-merge-robot openshift-merge-robot merged commit 5bbbc99 into containers:master Apr 22, 2020
@cevich cevich deleted the add_f32 branch June 30, 2021 18:12
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants