podman-save: log when more than one image is specified #5659
Conversation
Podman save can only save one image. While we are planning to support multiple images to catch up with Docker, we still need time to get the work done. Instead of ignoring other arguments, log when there are more than one. Signed-off-by: Valentin Rothberg <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
| @@ -70,6 +71,10 @@ func saveCmd(c *cliconfig.SaveValues) error { | |||
| return errors.Errorf("need at least 1 argument") | |||
| } | |||
|
|
|||
| if len(args) > 1 { | |||
| logrus.Errorf("only the first image will be saved but %d are specified", len(args)) | |||
| } | |||
There was a problem hiding this comment.
LocalRuntime.SaveImage uses c.inputArgs[1:] as DockerArchiveAdditionalTags. That might be not what the command is expected to do — but this breaks that.
So, either that functionality is useful, and this error needs to be removed (or reworded, or… I don’t know), or it is not, and it should be removed from the code. I guess the former.
|
☔ The latest upstream changes (presumably #5852) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Closing for now. |
github-actions
bot
added
the
locked - please file new issue/PR
Podman save can only save one image. While we are planning to support
multiple images to catch up with Docker, we still need time to get the
work done.
Instead of ignoring other arguments, log when there are more than one.
Signed-off-by: Valentin Rothberg [email protected]