WIP: Vendor https://github.com/containers/storage/pull/473 for testing

[saschagrunert]

To verify that containers/storage#473 works (or not)

[rhatdan]

#5700 Should help fix this.

[TomSweeneyRedHat]

@saschagrunert looks like some lint errors in the unshare package.

[rh-atomic-bot]

☔ The latest upstream changes (presumably #5700) made this pull request unmergeable. Please resolve the merge conflicts.

[rhatdan]

Rebase and this should at least compile now.

[saschagrunert]

Rebased on top of the latest master.

[rh-atomic-bot]

☔ The latest upstream changes (presumably #5727) made this pull request unmergeable. Please resolve the merge conflicts.

[rhatdan]

@saschagrunert Needs a rebase again.

[saschagrunert]

Hm this issue does not seem reproducible locally to me:

Error: error committing container for step {Env:[PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin] Command:run Args:[apk add bash] Flags:[] Attrs:map[] Message:RUN apk add bash Original:RUN apk add bash}: error copying layers and metadata for container "e1d34b849fc5ef59630cebd2a5a7d146604e09db3de35e40d41e4d94c68f69a3": Error reading blob sha256:c82ab33dce84c975f00a42224fa2914b27a943c1175175f67483f4eebdaaf198: error opening file "/var/tmp/buildah155921171/sha256:c82ab33dce84c975f00a42224fa2914b27a943c1175175f67483f4eebdaaf198" to buffer layer blob: open /var/tmp/buildah155921171/sha256:c82ab33dce84c975f00a42224fa2914b27a943c1175175f67483f4eebdaaf198: no such file or directory

[rhatdan]

@giuseppe PTAL

[saschagrunert]

This PR should be green now with the latest changes in containers/storage#473

[saschagrunert]

Look how partially green! :)

[github-actions]

A friendly reminder that this PR had no activity for 30 days.

[rhatdan]

@saschagrunert Are you getting back to this one?

[saschagrunert]

@rhatdan yes, can we move forward with the related PR in containers/storage? (containers/storage#473)

[rhatdan]

@saschagrunert Could you update this PR to prove that the containers/storage PR still works?

[saschagrunert]

Rebased the referencing PR as well as this one on top of their latest master branches. 👍

[saschagrunert]

Sooo there seems to be an issue now…

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: saschagrunert
To complete the pull request process, please assign mrunalp
You can assign the PR to them by writing /assign @mrunalp in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[saschagrunert]

Hmmm…

[+0331s] not ok 50 podman exec - with keep-id
         # (from function `die' in file test/system/helpers.bash, line 287,
         #  from function `run_podman' in file test/system/helpers.bash, line 170,
         #  in test file test/system/075-exec.bats, line 105)
         #   `run_podman exec --user=$(id -un) $cid touch /stop' failed with status 255
         # # podman rm --all --force
         # # podman images --all --format {{.Repository}}:{{.Tag}} {{.ID}}
         # quay.io/libpod/alpine_labels:latest 4fab981df737
         # # podman run -d --userns=keep-id quay.io/libpod/alpine_labels:latest sh -c echo READY;while [ ! -f /stop ]; do sleep 1; done
         # 396f4537b154ca0d86d607a66f7520c88e271d3619a2b0d2ddeedcaac4d1db2b
         # # podman logs 396f4537b154ca0d86d607a66f7520c88e271d3619a2b0d2ddeedcaac4d1db2b
         # READY
         # # podman exec 396f4537b154ca0d86d607a66f7520c88e271d3619a2b0d2ddeedcaac4d1db2b id -un
         # root
         # # podman exec --user=root 396f4537b154ca0d86d607a66f7520c88e271d3619a2b0d2ddeedcaac4d1db2b touch /stop
         # Error: unable to find user root: no matching entries in passwd file
         # [ rc=255 (** EXPECTED 0 **) ]
         # #/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
         # #| FAIL: exit code is 255; expected 0
         # #\^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
         # # [teardown]
         # # podman pod rm --all --force
         # # podman rm --all --force
         # 396f4537b154ca0d86d607a66f7520c88e271d3619a2b0d2ddeedcaac4d1db2b

[rhatdan]

@saschagrunert Please rebase this PR.

[saschagrunert]

I've switched forks, continuing in a new PR: #7603