Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Vendor https://github.com/containers/storage/pull/473 for testing #7603

Closed
wants to merge 1 commit into from
Closed

[WIP] Vendor https://github.com/containers/storage/pull/473 for testing #7603

wants to merge 1 commit into from

Conversation

saschagrunert
Copy link
Member

To verify that containers/storage#473 works (or not)

@saschagrunert saschagrunert mentioned this pull request Sep 11, 2020
Closed
@rhatdan rhatdan changed the title Vendor https://github.com/containers/storage/pull/473 for testing [WIP] Vendor https://github.com/containers/storage/pull/473 for testing Sep 11, 2020
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 11, 2020
@saschagrunert
Copy link
Member Author

I'm wondering why the remote CLI tests are failing 🤔

@rhatdan
Copy link
Member

rhatdan commented Sep 15, 2020

Will try again, if they fail again, you might have an issue. Theoretically containers/storage should not be involved in remote.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2020
@TomSweeneyRedHat
Copy link
Member

@saschagrunert now it needs a rebase.

@saschagrunert saschagrunert mentioned this pull request Oct 30, 2020
Closed
@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 2, 2020
@github-actions
Copy link

github-actions bot commented Dec 3, 2020

A friendly reminder that this PR had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Dec 4, 2020

@saschagrunert Needs a rebase.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2021
@saschagrunert
Copy link
Member Author

Rebased on top of the latest master and containers/storage#473 PR

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2021
@openshift-ci-robot
Copy link
Collaborator

@saschagrunert: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lastthyme, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrothberg
Copy link
Member

@saschagrunert, can we close this PR or is it in your pipeline?

I am going through some older issues and PRs at the moment.

@saschagrunert
Copy link
Member Author

Yes, let's close this one for now.

@saschagrunert saschagrunert deleted the vendor-ro-mod branch May 4, 2021 12:27
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mheon mheon Awaiting requested review from mheon

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. stale-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@saschagrunert @rhatdan @TomSweeneyRedHat @openshift-ci-robot @vrothberg