Use containers/common unshare package and remove internal #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes build issues where projects vendor containers/storage and containers/common because the unshare packages clash when trying to build them via cgo. Signed-off-by: Sascha Grunert <[email protected]>
|
containers/common v1.0.0 was reverted, and I have no idea where it is coming from. Something is strange on github, that this is showing up. |
|
If we update buildah/storage/common at the same time, I think it will get through this issue. |
|
Hopefully containers/podman#5700 |
|
Okay thank you for the heads up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes build issues where projects vendor containers/storage and
containers/common because the unshare packages clash when trying to
build them via cgo.
PS: Thats the reason why I cannot test #473 in containers/podman#5706 and cri-o/cri-o#3521 right now.
See: https://circleci.com/gh/openSUSE/cri-o/42914?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link