Fix play kube command #3588
Merged
Fix play kube command #3588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mheon
reviewed
Jul 17, 2019
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
haircommander
force-pushed
the
play-kube-command
branch
from
4df4614 to
b90cad1
Compare
Before, play kube wasn't properly setting the command. Fix this Also, begin a dedicated test suite for play kube to catch regressions like this in the future Signed-off-by: Peter Hunt <[email protected]>
haircommander
force-pushed
the
play-kube-command
branch
from
b90cad1 to
6f35a57
Compare
|
happy green tests @rhatdan @vrothberg @TomSweeneyRedHat @QiWang19 @mheon PTAL |
|
LGTM on my side. Like seeing integration tests. |
|
/lgtm |
|
@haircommander This fix was broken again in Podman v1.5.0. |
|
How so? Can you file an issue?
…On Wed, Aug 14, 2019, 02:02 Chen Zhiwei ***@***.***> wrote:
@haircommander <https://github.com/haircommander> This fix was broken
again in Podman v1.5.0.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3588>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB3AOCECK7S3ZYCJG7RWVGTQEONXRANCNFSM4IESQBOA>
.
|
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, play kube wasn't properly setting the command. Fix this
Also, begin a dedicated test suite for play kube to catch regressions like this in the future
Begins to fix #3286
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1729369
Signed-off-by: Peter Hunt [email protected]