Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for play kube #3286

Closed
haircommander opened this issue Jun 8, 2019 · 4 comments · Fixed by #3588
Closed

Unit tests for play kube #3286

haircommander opened this issue Jun 8, 2019 · 4 comments · Fixed by #3588
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@haircommander
Copy link
Collaborator

/kind feature
??

We have broken play kube numerous times because we don't really test it.

considering it's a feature that is advertised and promoted, we should probably have tests to stop it from breaking

@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 8, 2019
@haircommander
Copy link
Collaborator Author

@rhatdan I can't give this love right now, but it also seems like an accessible task for interns.

please close if I missed a discussion about how this isn't viable.

@mheon
Copy link
Member

mheon commented Jun 8, 2019

Ideal test flow is probably a test that makes a pod, does a podman generate kube of that pod, removes said pod, and imports again with play kube, verifying that the appropriate number of containers are created, names are preserved, etc.

@mheon
Copy link
Member

mheon commented Jun 11, 2019

I got this one - #3293

@mheon mheon assigned mheon and unassigned QiWang19 Jun 11, 2019
@mheon mheon closed this as completed Jun 11, 2019
@vrothberg
Copy link
Member

I am currently having a hard time running YAML files I find on the web, so I was looking for issues.

#3293 was adding unit tests but those are using podman to generate the YAML files. This is a bit problematic as podman is testing itself and we don't have a predefined behaviour we can test against.

I'd love to have a set of YAML files that we test against in addition to the generate-play cycle tests.

@vrothberg vrothberg reopened this Jul 4, 2019
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants