Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for 'podman play kube' to prevent regression #3293

Merged
merged 2 commits into from
Jun 11, 2019
Merged

Add a test for 'podman play kube' to prevent regression #3293

merged 2 commits into from
Jun 11, 2019

Conversation

mheon
Copy link
Member

@mheon mheon commented Jun 10, 2019

As the title says.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M labels Jun 10, 2019
@haircommander
Copy link
Collaborator

LGTM

@rhatdan
Copy link
Member

rhatdan commented Jun 10, 2019

LGTM
Once you fix your testing/building issues.

@mheon mheon force-pushed the add_test_for_play_kube branch from 3cfe06e to 5eca8c6 Compare June 10, 2019 19:39
@mheon mheon force-pushed the add_test_for_play_kube branch from 5eca8c6 to 53435d4 Compare June 10, 2019 22:57
@mheon
Copy link
Member Author

mheon commented Jun 11, 2019

The generated YAML works on my machine, so I'm not sure what's going on here. Probably issues writing the output of 'generate kube' to file.

I might just add a --file to generate kube to specify an output file for simplicity.

@mheon
Copy link
Member Author

mheon commented Jun 11, 2019

Added --filename, -f flag to generate kube. Let's see if the tests start passing.

@mheon
Add --filename option to generate kube
f909b74 
This allows writing output directly to a file, instead of STDOUT.
Makes things easier for some scripting tasks. Like the unit tests
for 'play kube'.

Signed-off-by: Matthew Heon <[email protected]>
@mheon mheon force-pushed the add_test_for_play_kube branch from 2e14951 to f909b74 Compare June 11, 2019 15:26
@mheon mheon mentioned this pull request Jun 11, 2019
Closed
@mheon
Copy link
Member Author

mheon commented Jun 11, 2019

@rhatdan @haircommander @giuseppe @baude Anyone want to hit this with an LGTM? Tests went green

@haircommander
Copy link
Collaborator

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2019
@openshift-merge-robot openshift-merge-robot merged commit 130f6cb into containers:master Jun 11, 2019
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giuseppe giuseppe Awaiting requested review from giuseppe

@jwhonce jwhonce Awaiting requested review from jwhonce

Assignees

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mheon @openshift-ci-robot @haircommander @rhatdan @openshift-merge-robot