Fix play kube command in pod yaml

[chenzhiwei]

This PR fixes the play kube can't recognize command setting in pod yaml file.

The initial issue was fixed in: #3588

But it was introduced again in: #3744

/assign @haircommander @mheon

[openshift-ci-robot]

Hi @chenzhiwei. Thanks for your PR.

I'm waiting for a containers or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rh-atomic-bot]

Can one of the admins verify this patch?
I understand the following commands:

• bot, add author to whitelist
• bot, test pull request
• bot, test pull request once

[haircommander]

LGTM, @mheon I wonder why this wasn't caught in tests 🤔

[haircommander]

bot, add author to whitelist
/ok-to-test
thanks for the PR @chenzhiwei

[haircommander]

@chenzhiwei I am trying to write a test case that replicates the problem, but can't on the current master. if I have the kube yaml:

# Generation of Kubernetes YAML is still under development!
#
# Save the output of this file and use kubectl create -f to import
# it into Kubernetes.
#
# Created with podman-1.4.5-dev
apiVersion: v1
kind: Pod
metadata:
  creationTimestamp: "2019-08-14T12:27:01Z"
  labels:
    app: hello
  name: hello
spec:
  containers:
  - command:
    - /bin/sh
    - -c
    - echo "hello"
    env:
    - name: PATH
      value: /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
    - name: TERM
      value: xterm
    - name: HOSTNAME
    - name: container
      value: podman
    image: docker.io/library/alpine:latest
    name: wonderfulpoincare
    resources: {}
    securityContext:
      allowPrivilegeEscalation: true
      capabilities: {}
      privileged: false
      readOnlyRootFilesystem: false
    workingDir: /
status: {}

and play kube with it, I can then run
podman logs -l
and get "hello" back

How did you find this problem?

[TomSweeneyRedHat]

This smells like a bad merge somewhere....

[TomSweeneyRedHat]

LGTM, if we could add a test, either in this PR or another to watch for another regression, it would probably be a good idea.

[TomSweeneyRedHat]

and forgot the most important thing, Thanks @chenzhiwei !

[chenzhiwei]

@haircommander Which version did you use?

Mine is:

root@ubuntu:~# podman version
Version:            1.5.0
RemoteAPI Version:  1
Go Version:         go1.10.4
OS/Arch:            linux/amd64

And use your yaml file, I got:

root@ubuntu:~# podman ps -a
CONTAINER ID  IMAGE                            COMMAND               CREATED         STATUS                     PORTS  NAMES
cac3c431eb10  docker.io/library/alpine:latest  /bin/sh               20 seconds ago  Exited (0) 19 seconds ago         wonderfulpoincare
bd57c8608ebd  k8s.gcr.io/pause:3.1                                   25 seconds ago  Up 20 seconds ago                 8197b58ea5f2-infra

[mheon]

Oh, oops. This won't trigger on run - instead it'll blank out CMD on commit of the image (and on inspect).

…

On Wed, Aug 14, 2019, 09:04 Tom Sweeney ***@***.***> wrote: ***@***.**** commented on this pull request. This smells like a bad merge somewhere.... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3809>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB3AOCAB2Y5HRQ4UQ2KP3ELQEP7D7ANCNFSM4ILR3CEA> .

[haircommander]

@chenzhiwei confirmed ps shows the wrong output. This has the side effect of a regression in generate kube where the command isn't properly set...

I have a test case attached, can you apply it with git apply -f play-patch.txt
play-patch.txt

[haircommander]

haha whoops, you'll need to run make gofmt and commit the changes

[haircommander]

LGTM assuming the test passes :) thanks a bunch @chenzhiwei
@mheon added Release Notes 1.5.1 to make sure this gets in :)

[mheon]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenzhiwei, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mheon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chenzhiwei]

@haircommander Sorry, I did not verify the final result, it was just a display error.

I have vim-go installed, usually there should be no format error, but for this patch I did not use vim to edit it. :(

[haircommander]

no worries at all 😃

[haircommander]

/lgtm