Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Followup to #2456: update examples, add trust #2463

Merged
merged 4 commits into from
Feb 27, 2019
Merged

Followup to #2456: update examples, add trust #2463

merged 4 commits into from
Feb 27, 2019

Conversation

edsantiago
Copy link
Member

  • belatedly incorporate review feedback from baude
  • add usage synopsis for trust-set and trust-show

Signed-off-by: Ed Santiago [email protected]

@openshift-ci-robot openshift-ci-robot added size/S needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 27, 2019
@openshift-ci-robot
Copy link
Collaborator

Hi @edsantiago. Thanks for your PR.

I'm waiting for a containers or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@edsantiago
Copy link
Member Author

@baude sorry I slept in this morning

@rhatdan
Copy link
Member

rhatdan commented Feb 27, 2019

/ok-to-test
/approve

@openshift-ci-robot openshift-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 27, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2019
@rhatdan
Copy link
Member

rhatdan commented Feb 27, 2019

LGTM

@edsantiago edsantiago mentioned this pull request Feb 27, 2019
Merged
TomSweeneyRedHat
TomSweeneyRedHat reviewed Feb 27, 2019
View reviewed changes
cmd/podman/checkpoint.go
podman checkpoint --leave-running --latest`,
Example: `podman container checkpoint --keep ctrID
podman container checkpoint --all
podman container checkpoint --leave-running --latest`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, ty for the fix up!

TomSweeneyRedHat
TomSweeneyRedHat reviewed Feb 27, 2019
View reviewed changes
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing these changes @edsantiago !

@mheon
Copy link
Member

mheon commented Feb 27, 2019

LGTM once Tom's comments are addressed

TomSweeneyRedHat
TomSweeneyRedHat reviewed Feb 27, 2019
View reviewed changes
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming happy tests.

@TomSweeneyRedHat
Copy link
Member

ubuntu failing here too...

@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #2471) made this pull request unmergeable. Please resolve the merge conflicts.

@edsantiago
Followup to containers#2456: update examples, add trust
9a3a59c 
- belatedly incorporate review feedback from baude
- add usage synopsis for trust-set and trust-show

Signed-off-by: Ed Santiago <[email protected]>
@edsantiago
fixup! Correction to 'checkpoint'
69808ff 
...it's a subcommand of 'podman container'

Signed-off-by: Ed Santiago <[email protected]>
@edsantiago
fixup! missed some more:
7a66ad7 
- [flags] in generate-kube
- optional [IMAGE] in images

Signed-off-by: Ed Santiago <[email protected]>
@edsantiago
fixup! Incorporate review feedback
2c0909b 
Per tsweeney, add back the original examples

Signed-off-by: Ed Santiago <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Feb 27, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2019
@openshift-merge-robot openshift-merge-robot merged commit 8d120ba into containers:master Feb 27, 2019
@edsantiago edsantiago deleted the missed_some_synopses branch February 27, 2019 22:15
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

@baude baude Awaiting requested review from baude

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@edsantiago @openshift-ci-robot @rhatdan @mheon @TomSweeneyRedHat @rh-atomic-bot @openshift-merge-robot