Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove restore as podman subcommand #2460

Merged
merged 1 commit into from
Feb 27, 2019

Conversation

adrianreber
Copy link
Collaborator

The commands checkpoint and restore should only be available under
'podman container'. This is probably a result of the recent cobra
migration.

Signed-off-by: Adrian Reber [email protected]

The commands checkpoint and restore should only be available under
'podman container'. This is probably a result of the recent cobra
migration.

Signed-off-by: Adrian Reber <[email protected]>
@adrianreber
Copy link
Collaborator Author

Fix for the inconsistency reported in #2191

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
LGTM

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianreber, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2019
@rhatdan
Copy link
Member

rhatdan commented Feb 27, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2019
@openshift-merge-robot openshift-merge-robot merged commit 87f0b36 into containers:master Feb 27, 2019
@edsantiago
Copy link
Member

Would it make sense to also, within this PR, update cmd/podman/checkpoint.go:35-37, changing podman checkpoint to podman container checkpoint?

@edsantiago
Copy link
Member

[oops, never mind]

@adrianreber
Copy link
Collaborator Author

@edsantiago I will fix that in a new PR. Thanks for pointing it out.

@edsantiago
Copy link
Member

@adrianreber I've piggybacked it onto #2463

@adrianreber
Copy link
Collaborator Author

@edsantiago thanks.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants