-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better usage synopses for subcommands #2456
Better usage synopses for subcommands #2456
Conversation
Hi @edsantiago. Thanks for your PR. I'm waiting for a containers or openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
VERY LOW PRIORITY. And I realize of course that I'll need to rebase after (if) #2452 is merged. I also realize it'll be tedious to review. I'm sorry. Possible suggestions:
@baude PTAL but again very low priority |
CI failure: gating: because I added |
Conceptually simple: include, where applicable, a brief description of command-line options for each subcommand. Signed-off-by: Ed Santiago <[email protected]>
bdfa43b
to
a20ff42
Compare
/ok-to-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@edsantiago i think this looks great... given it is outward facing, would like thumb up from @rhatdan and @mheon . i pulled the PR and really like how it looks. Adding example for the fellas here:
|
/lgtm |
- belatedly incorporate review feedback from baude - add usage synopsis for trust-set and trust-show Signed-off-by: Ed Santiago <[email protected]>
Followup to #2456: update examples, add trust
Conceptually simple: include, where applicable, a brief
description of command-line options for each subcommand.
Signed-off-by: Ed Santiago [email protected]