Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI:BUILD] copr: enable podman-restart.service on rpm installation #16672

Merged
merged 1 commit into from
Nov 30, 2022
Merged

[CI:BUILD] copr: enable podman-restart.service on rpm installation #16672

merged 1 commit into from
Nov 30, 2022

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Nov 29, 2022 •
edited
Loading

Resolves: #16669

@rhatdan PTAL

Signed-off-by: Lokesh Mandvekar [email protected]

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 29, 2022
@lsm5 lsm5 force-pushed the copr-podman-restart branch from 6ed0005 to 97ad001 Compare November 29, 2022 14:20
@rhatdan
Copy link
Member

rhatdan commented Nov 29, 2022

LGTM
@vrothberg @containers/podman-maintainers PTAL

@Luap99
Copy link
Member

Luap99 commented Nov 29, 2022

Also restart podman-restart.service on upgrade.

Why should it restart on updates? If my containers are already running I do not want them to be restarted for a podman update.

@lsm5
Copy link
Member Author

lsm5 commented Nov 29, 2022

Also restart podman-restart.service on upgrade.

Why should it restart on updates? If my containers are already running I do not want them to be restarted for a podman update.

alright, I can make that change.

@lsm5 lsm5 force-pushed the copr-podman-restart branch from 97ad001 to 0521748 Compare November 29, 2022 15:48
@lsm5
Copy link
Member Author

lsm5 commented Nov 29, 2022

done

vrothberg
vrothberg approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

Thanks!

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lsm5
Copy link
Member Author

lsm5 commented Nov 30, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2022
@openshift-merge-robot openshift-merge-robot merged commit b294b7c into containers:main Nov 30, 2022
@Luap99 Luap99 mentioned this pull request Dec 9, 2022
Closed
@benoitf benoitf mentioned this pull request Dec 9, 2022
Open
@lsm5 lsm5 deleted the copr-podman-restart branch March 16, 2023 11:25
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg approved these changes

Assignees

@vrothberg vrothberg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

podman restart systemd unit file should be enabled after installing the podman package.
5 participants
@lsm5 @rhatdan @Luap99 @vrothberg @openshift-merge-robot