Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic restart for kind containers #16797

Closed
benoitf opened this issue Dec 9, 2022 · 12 comments
Closed

Automatic restart for kind containers #16797

benoitf opened this issue Dec 9, 2022 · 12 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. podman-desktop stale-issue

Comments

@benoitf
Copy link
Contributor

benoitf commented Dec 9, 2022

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind feature

Description

Using kind, I'm able to deploy a kubernetes cluster.
But when restarting the podman machine, the control-plane container is not restarted, meaning that my cluster is not up so the experience is not nice.

There is an existing issue on kind kubernetes-sigs/kind#2272 but it says that

podman lacks automatic restart for containers and lacks sufficient networking features to design robust restart. Node addresses will be random and restart support will be a roll of the dice

so it would be nice if Podman fixes the issue in order to have kind clusters restart being done properly.

Steps to reproduce the issue:

  1. enable podman experimental support in kind export KIND_EXPERIMENTAL_PROVIDER=podman

  2. create cluster with kind create cluster

  3. stop podman machine (for example on macOS) and restart the machine

Describe the results you received:
control-plane container is not restarted

Describe the results you expected:
control-plane container is restarted

Additional information you deem important (e.g. issue happens only occasionally):

Output of podman version:

(paste your output here)

Output of podman info:

(paste your output here)

Package info (e.g. output of rpm -q podman or apt list podman or brew info podman):

(paste your output here)

Have you tested with the latest version of Podman and have you checked the Podman Troubleshooting Guide?

Yes/No

Additional environment details (AWS, VirtualBox, physical, etc.):

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 9, 2022
@benoitf benoitf changed the title Automatic restart for containers Automatic restart for kind containers Dec 9, 2022
@Luap99
Copy link
Member

Luap99 commented Dec 9, 2022

It is not clear to me what they are doing but with --restart always the container can be started on boot when podman-restart.service is enabled, which is the default going forward (#16672)

@benoitf
Copy link
Contributor Author

benoitf commented Dec 9, 2022

and about Node addresses will be random and restart support will be a roll of the dice. ?

@Luap99
Copy link
Member

Luap99 commented Dec 9, 2022

and about Node addresses will be random and restart support will be a roll of the dice. ?

I have absolutely no idea what they are referring to.

@benoitf
Copy link
Contributor Author

benoitf commented Dec 9, 2022

and there is a comment saying

You have to use podman restart kind-control-plane.
podman start does not reattach the port forwarding.

@Luap99
Copy link
Member

Luap99 commented Dec 9, 2022

I need to know the extract podman commands to reproduce, I have no interest in debugging kind and I am not aware of any port forwarding problems with podman start.

@aojea
Copy link
Contributor

aojea commented Dec 10, 2022

kind developer here, the problems are explained in the kind issue, is not a problem of allowing restart in podman only or really a bug in podman,, kind relies on some behaviors on the network and podman architecture is different to the docker one and are features that are not compatible, that means that s/docker/podman/ doesn't work in kind automatically, some of the issues are:

@Luap99
Copy link
Member

Luap99 commented Dec 10, 2022

lack of centralized dns, I don't know how it is done now in podman

We use https://github.com/containers/aardvark-dns/ now, this is much closer to what docker is doing so it might already work for your use case if not I am happy to hear what is missing.

@aojea
Copy link
Contributor

aojea commented Dec 10, 2022

yeah, things and projects are converging ... but users always wants things to happen immediately ;)

@vrothberg
Copy link
Member

Thanks for sharing, @aojea! Does it work with aardvark? If there are missing pieces, please let us know and we'll tackle them.

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Jan 18, 2023

Since we never heard a response, I am closing reopen if you have more feedback.

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan rhatdan closed this as completed Feb 21, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. podman-desktop stale-issue
Projects
None yet
Development

No branches or pull requests

5 participants