Add container restart policy when using podman

[bpfoster]

What would you like to be added: The kind-control-plane container to have a restart policy when launched with podman

Why is this needed: The container has a restart policy when launched with docker, but launching with podman does not set this policy.

While it's true that podman doesn't handle restarts on its own, since v3.3.0, podman does come with an available systemd service that will restart all containers with restart-policy=always.

I realize this is a different policy than is used with docker. It would be nice to use the systemd service was-is (requiring an always restart policy), but even if you chose to set the same on-failure policy as is used on docker, a copy/paste/tweak could be made to the systemd service file to make it work as expected.

This would be nice to be able to utilize so that whenever I restart the machine, or logout/login, the kind cluster comes up automatically like I have come to expect in a docker environment.

Supporting information:

$ docker inspect kind-control-plane --format '{{ .HostConfig.RestartPolicy.Name }}' 
on-failure

$ podman inspect kind-control-plane --format '{{ .HostConfig.RestartPolicy.Name }}'

Kind docker provisioner:
https://github.com/kubernetes-sigs/kind/blob/main/pkg/cluster/internal/providers/docker/provision.go#L166

Kind podman provisioner:
https://github.com/kubernetes-sigs/kind/blob/main/pkg/cluster/internal/providers/podman/provision.go#L170

[BenTheElder]

Always is not a very appropriate policy (see the lengthy code comment on the docker policy).

is that service always enabled?

[BenTheElder]

Also, podman based multi node clusters probably won't restart properly anyhow, because the lack of container hostname resolution vs docker embedded dns.

[bpfoster]

is that service always enabled?

It was not enabled on my distro by default, had to do that like so:
systemctl --user enable podman-restart.service

[BenTheElder]

ACK, I think this is a dupe of #2272

[benoitf]

the podman-restart.service should be included on Podman 4.4.0 and onwards
containers/podman#16672
containers/podman#16669

[aojea]

the podman-restart.service should be included on Podman 4.4.0 and onwards

the problem is how do you support a feature like that on old versions? we already have a lot of if version x do Y else do Z and that is very complex to support and sustain