Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update buildah and c/common to latest #15695

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Update buildah and c/common to latest #15695

merged 2 commits into from
Sep 9, 2022

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Sep 8, 2022

Does this PR introduce a user-facing change?

Add new --retry --retry-delay options to podman build to configure the image pull retries on errors.

@Luap99 Luap99 changed the title Update buildah adn c/common to latest Update buildah and c/common to latest Sep 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2022
@Luap99
Copy link
Member Author

Luap99 commented Sep 8, 2022 •
edited
Loading

Looks like there is a regression while pulling images?

time="2022-09-08T16:00:05Z" level=error msg="While applying layer: ApplyLayer stdout:  stderr: time=\"2022-09-08T16:00:05Z\" level=error msg=\"finding config on system: lstat /root/.config/containers/containers.conf.d: permission denied\"\n exit status 1"
         Error: copying system image from manifest list: writing blob: adding layer with blob "sha256:f513001ba4ab7a43f17471022e7424b6ce08110b766d6903ccff1fdea3c5210a": ApplyLayer stdout:  stderr: time="2022-09-08T16:00:05Z" level=error msg="finding config on system: lstat /root/.config/containers/containers.conf.d: permission denied"

@mtrmac @vrothberg PTAL

@Luap99 Luap99 mentioned this pull request Sep 8, 2022
Draft
@edsantiago
Copy link
Member

So.... I last pushed a treadmill update five days ago, and all tests passed. That means it should be very easy to narrow down the breakage... and the diffs are very small... but unfortunately it is beyond my ability to track down. So I'll leave this in your hands.

$ git pr 13808          ! assumes you have git-extras installed; otherwise do whatever you do to pull PRs
$ git diff pr/13808 update-buildah -- vendor        ! what changed, under vendor, between working commit and this one?

HTH

@Luap99
Copy link
Member Author

Luap99 commented Sep 8, 2022

Not so small: containers/common#1149

Anyway I cannot reproduce this locally so I am unable to debug.

@edsantiago
Copy link
Member

Oh..... you're bumping c/common, storage, image too. I missed that. Okay, may the Force be with you.

@Luap99
Copy link
Member Author

Luap99 commented Sep 8, 2022

ok I can reproduce with ./test/compose/test-compose but not with regular podman pull (local and remote).

@giuseppe I think containers/storage#1312 causes the problem, when I reverted that part it works again. PTAL

@rhatdan
Copy link
Member

rhatdan commented Sep 8, 2022

@giuseppe PTAL

@Luap99 Luap99 mentioned this pull request Sep 9, 2022
Merged
@Luap99 Luap99 marked this pull request as draft September 9, 2022 08:34
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2022
Luap99 and others added 2 commits September 9, 2022 11:58
@Luap99
update buildah and c/common to latest
eb28a1c 
also includes bumps for c/storage and c/image

Signed-off-by: Paul Holzinger <[email protected]>
@edsantiago @Luap99
Fixes for vendoring Buildah
8e1aa7a 
This commit was automatically cherry-picked
by buildah-vendor-treadmill v0.3
from the buildah vendor treadmill PR, containers#13808

Changes since 2022-08-16:

 - buildah 4139: minor line-number changes to the diff
   file because helpers.bash got edited

 - buildah 4190: skip the new test if remote

 - buildah 4195: add --retry / --retry-delay

 - changes to deal with vendoring gomega, units

 - changes to the podman login error message in system test

Signed-off-by: Paul Holzinger <[email protected]>
@Luap99 Luap99 marked this pull request as ready for review September 9, 2022 11:08
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2022
@Luap99
Copy link
Member Author

Luap99 commented Sep 9, 2022

@containers/podman-maintainers PTAL

vrothberg
vrothberg reviewed Sep 9, 2022
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Luap99
Copy link
Member Author

Luap99 commented Sep 9, 2022

Looks like containers/image#1487 is working not only in the diff stat but also binary size:

bin/podman           size= 47322448  delta=-667400
bin/podman-remote    size= 35459920  delta=-766528

@vrothberg
Copy link
Member

https://github.com/orgs/containers/teams/podman-maintainers PTAL

@rhatdan
Copy link
Member

rhatdan commented Sep 9, 2022

/lgtm

@vrothberg vrothberg mentioned this pull request Sep 9, 2022
Closed
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2022
@openshift-merge-robot openshift-merge-robot merged commit 04270a0 into containers:main Sep 9, 2022
@Luap99 Luap99 deleted the update-buildah branch September 9, 2022 13:09
@edsantiago edsantiago mentioned this pull request Oct 6, 2022
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Luap99 @edsantiago @rhatdan @vrothberg @openshift-merge-robot