chrootarchive: propagate env from parent #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This currently changes two of the places where we call |
giuseppe
force-pushed
the
fix-apply-layer-in-userns
branch
from
af94af0 to
431ee8c
Compare
I've touched only the file that I was working on as part of the fix. I agree it makes no sense to change only that, so I've adapted other files as well and pushed a new version |
giuseppe
force-pushed
the
fix-apply-layer-in-userns
branch
from
431ee8c to
96ea882
Compare
use the function in containers/storage that has the same functionalities. Signed-off-by: Giuseppe Scrivano <[email protected]>
propagate the environment variables from the current process since they are needed by pkg/unshare to read the UID for the user that created the user namespace (through the _CONTAINERS_ROOTLESS_UID env variable). Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
fix-apply-layer-in-userns
branch
from
96ea882 to
9ecda58
Compare
|
LGTM |
|
I applied this fix in containers/podman#15695 and it seems to work (at least the compose and API tests which failed previously are now green). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
propagate the environment variables from the current process since they are needed by pkg/unshare to read the UID for the user that created the user namespace (through the _CONTAINERS_ROOTLESS_UID env variable).
Signed-off-by: Giuseppe Scrivano [email protected]