bump buildah to v1.25.1 #13733
Closed
bump buildah to v1.25.1 #13733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
For some reason the bump downgrades c/common because go thinks that v0.47.5 is newer that what we have at the moment. This is wrong so we manually overwrite this with an replace. The replace can be removed when we have a new tagged c/common release. [NO NEW TESTS NEEDED] Signed-off-by: Paul Holzinger <[email protected]>
|
Test failures are legit, I created containers/buildah#3885 to fix it. |
|
@Luap99 You want to update this one? 4.0 branch is fixed, but we should probably fix main as well |
|
I can vendor buildah main or we need a new buildah tag |
|
Hopefully #13687 will get this in. |
|
Since PR #13687 merged, this PR is no longer necessary. |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the bump downgrades c/common because go thinks that
v0.47.5 is newer that what we have at the moment. This is wrong so we
manually overwrite this with an replace. The replace can be removed when
we have a new tagged c/common release.