Bump to Buildah v1.25.1, openshift/imagebuilder v1.2.3

[TomSweeneyRedHat]

[NO NEW TESTS NEEDED]

This bumps Buildah to v1.25.1 and openshift/imagebuilder to v1.2.3

Signed-off-by: tomsweeneyredhat [email protected]

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [TomSweeneyRedHat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[TomSweeneyRedHat]

I'm leery about adding the "replace" command for containers/common, but for the moment, it's the quickest way around a nasty vendor dance that we're undergoing. We should talk at standup tomorrow about the state of the c/common main branch and plans for the near future for it and the other branches. It's not clear to me at least.

@Luap99 @vrothberg PTAL

[edsantiago]

This is badly, badly broken. Common factor, best I can tell, is:

# podman build SOMETHING
STEP 1 FROM ... <----- is ok
STEP 2 RUN some command     <---- this is what fails
error running container: setting file label on "/proc/self/fd/12": lsetxattr /proc/self/fd/12: operation not supported

[TomSweeneyRedHat]

The problem seems to be pulling in this commit from c/common containers/common#971 and then the changes in Podman to use that. I tried to back that out of Podman temporarily, but I'm too tired to see straight at this point. @Luap99 or @vrothberg if you could take a look when you get in, I'd appreciate it.

[Luap99]

You have to remove this change to fix the tests, see #13687 containers/buildah#3875

[flouthoc]

@Luap99 I think we might wanna revert version bump of selinux in c/common cause make vendor will automatically bump selinux. Could you review my above PR.

[flouthoc]

@TomSweeneyRedHat I think you can do go mod edit -replace github.com/opencontainers/selinux=github.com/opencontainers/[email protected] till this is fixed or reverted in c/common

[TomSweeneyRedHat]

Closing, replaced by #13733