Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network create: add support for ipam-driver none #13701

Merged
merged 1 commit into from
Apr 11, 2022
Merged

network create: add support for ipam-driver none #13701

merged 1 commit into from
Apr 11, 2022

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Mar 29, 2022

Add a new flag to set the ipam-driver. Also adds a new ipam driver none
mode which only creates interfaces but does not assign addresses.

Fixes #13521

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2022
@Luap99 Luap99 force-pushed the ipam-none branch 2 times, most recently from 7b7f587 to efbfa21 Compare March 29, 2022 18:20
@Luap99
Copy link
Member Author

Luap99 commented Mar 30, 2022

This needs containers/common#989 to make the new test work with CNI.

@Luap99
Copy link
Member Author

Luap99 commented Apr 4, 2022

@containers/podman-maintainers PTAL

giuseppe
giuseppe approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

flouthoc
flouthoc reviewed Apr 5, 2022
View reviewed changes
go.mod Outdated

// builds are broken with selinux v1.10.1, see https://github.com/containers/buildah/pull/3875
// once PR is merged and vendored into podman we have to remove this
replace github.com/opencontainers/selinux => github.com/opencontainers/selinux v1.10.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already merged containers/buildah#3875 should we remove this ? However I think a vendor dance would be needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#13733 will vendor in a new buildah version
Updating buildah in this PR is out of scope IMO

@Luap99
Copy link
Member Author

Luap99 commented Apr 7, 2022

/hold
lets merge #13687 first

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 7, 2022
@Luap99
network create: add support for ipam-driver none
784a13f 
Add a new flag to set the ipam-driver. Also adds a new ipam driver none
mode which only creates interfaces but does not assign addresses.

Fixes containers#13521

Signed-off-by: Paul Holzinger <[email protected]>
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2022
@Luap99 Luap99 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2022
@Luap99
Copy link
Member Author

Luap99 commented Apr 11, 2022

@containers/podman-maintainers PTAL

@mheon
Copy link
Member

mheon commented Apr 11, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2022
@openshift-merge-robot openshift-merge-robot merged commit 8661631 into containers:main Apr 11, 2022
@Luap99 Luap99 deleted the ipam-none branch April 11, 2022 14:38
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flouthoc flouthoc flouthoc left review comments

@giuseppe giuseppe giuseppe approved these changes

Assignees

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow creating macvlan network without subnet when using netavark backend
5 participants
@Luap99 @mheon @giuseppe @flouthoc @openshift-merge-robot