Bump to v4.0.0-RC5

[mheon]

Also includes associated release notes updates and backports

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mheon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

We might want to hold this up untile @lsm5 Figures out containers/storage#1131

[mheon]

I'll leave this open to let CI bake, but I'm fine waiting for that to get resolved.

[mheon]

API unit tests are failing, on a test that seems to validate that the current version is compatible with the API. This makes me think the bump to v4.0.0 as the minimum is conflicting with the v4.0.0-dev version set.

[Luap99]

The api test are hard coded for v3.1,see

podman/test/apiv2/01-basic.at

Line 22 in 6d2b54a

.Components[0].Details.MinAPIVersion=3.1.0 \

You have to change this to 4.0 as well.

[mheon]

@Luap99 That's the APIv2 tests - the unit tests are failing very differently.

[mheon]

Specifically

podman/pkg/api/handlers/utils/handler_test.go

Lines 14 to 54 in 29d7ab3

	func TestSupportedVersion(t *testing.T) {
	req, err := http.NewRequest("GET",
	fmt.Sprintf("/v%s/libpod/testing/versions", version.APIVersion[version.Libpod][version.CurrentAPI]),
	nil)
	if err != nil {
	t.Fatal(err)
	}
	req = mux.SetURLVars(req, map[string]string{"version": version.APIVersion[version.Libpod][version.CurrentAPI].String()})
	rr := httptest.NewRecorder()
	handler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
	_, err := SupportedVersionWithDefaults(r)
	switch {
	case errors.Is(err, ErrVersionNotGiven): // for compat endpoints version optional
	w.WriteHeader(http.StatusInternalServerError)
	fmt.Fprint(w, err.Error())
	case errors.Is(err, ErrVersionNotSupported): // version given but not supported
	w.WriteHeader(http.StatusBadRequest)
	fmt.Fprint(w, err.Error())
	case err != nil:
	w.WriteHeader(http.StatusInternalServerError)
	fmt.Fprint(w, err.Error())
	default: // all good
	w.WriteHeader(http.StatusOK)
	fmt.Fprint(w, "OK")
	}
	})
	handler.ServeHTTP(rr, req)
	if status := rr.Code; status != http.StatusOK {
	t.Errorf("handler returned wrong status code: got %v want %v",
	status, http.StatusOK)
	}
	// Check the response body is what we expect.
	expected := `OK`
	if rr.Body.String() != expected {
	t.Errorf("handler returned unexpected body: got %q want %q",
	rr.Body.String(), expected)
	}
	}

is failing - returning 400 not 200

[edsantiago]

Three failures in int tests, all of them remote. Unfortunately I can't figure out any elements common to the failures.

[mheon]

It's all manifest changes. I don't think I did any backports that would affect that code?

[mheon]

I'm going to restart just one of the tests, in the hopes that it was transitory; if that passes we're probably OK.

[mheon]

Nope, failures are consistent. OK...

[mheon]

It's all manifest failures. Nearest I can tell there are no manifest-related changes in this PR, either to code or tests. I'm going to get another PR pushed to try and verify.

[mheon]

I don't know how, but bumping minimum API version breaks the Libpod API manifest endpoints. I want to debug this, but it's Friday afternoon, so I'm going to vote that we release the RC now and debug later.

[mheon]

One flake (I hope...) - restarted

[mheon]

Another flake. Restarted.

[mheon]

Ready

[rhatdan]

/lgtm