Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System tests: emergency skip of checkpoint tests #13049

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

edsantiago
Copy link
Member

...on kernel 5.17, because it's broken. Needed for gating tests on rawhide.

Signed-off-by: Ed Santiago [email protected]

...on kernel 5.17, because it's broken

Signed-off-by: Ed Santiago <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2022
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Jan 27, 2022

/hold
/lgtm

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2022
@edsantiago
Copy link
Member Author

@cevich any idea what's going on here? The Total Success is red. Clicking on it claims that the new remote rootless task failed, but it didn't, it shows as green here. This has been stuck for at least 30m.

@rhatdan rhatdan merged commit 908329c into containers:main Jan 27, 2022
@rhatdan
Copy link
Member

rhatdan commented Jan 27, 2022

I forced merge it.

@cevich
Copy link
Member

cevich commented Jan 27, 2022

The Total Success is red.

Damn...that's not right...investigating...

@cevich
Copy link
Member

cevich commented Jan 27, 2022

it shows as green here

Yeah, don't always believe the status reported by github. There is a (still) long open bug where it doesn't match what the CI system reports (especially after a re-run). This bug even affects github-actions...no idea why they refuse/can't fix it. Anyway, clicking on it now (in Cirrus WebUI) does show a failure (flake I think):

[+0414s] not ok 182 podman kill - test signal handling in containers
...cut...
[+0414s] # #/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
[+0414s] # #| FAIL: Timed out: no ACK for kill -s 25
[+0414s] # #\^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@edsantiago
Copy link
Member Author

I saw that too. However, looking at the CI results on github itself (both in the Conversation tab and the Checks one) shows all tests green, including the allegedly-failing one. My gut feel is that the test flaked, someone restarted it, then it passed, but Cirrus didn't get the memo that the test passed on rerun. I manually confirmed that the test did pass. I also compared task IDs (or job IDs or whatever, the long number starting with 6) and they were different.

@cevich
Copy link
Member

cevich commented Jan 27, 2022

Wait, you're right (re-run theory) this is somehow a mixup in Cirrus-CI, look closely at the build page: https://cirrus-ci.com/build/5960543587532800 There are TWO entries for sys remote fedora-35 rootless host. One red, one green. I'll let support know about this, it should never happen.

edsantiago added a commit to edsantiago/libpod that referenced this pull request Feb 3, 2022
Revert containers#13049. criu-3.16.1-6.fc36 fixes the problem and is
now in fc36 stable:

   https://bodhi.fedoraproject.org/updates/FEDORA-2022-183b337712

(Yes, I confirmed that tests pass on a rawhide vm)

Signed-off-by: Ed Santiago <[email protected]>
mheon pushed a commit to mheon/libpod that referenced this pull request Feb 10, 2022
Revert containers#13049. criu-3.16.1-6.fc36 fixes the problem and is
now in fc36 stable:

   https://bodhi.fedoraproject.org/updates/FEDORA-2022-183b337712

(Yes, I confirmed that tests pass on a rawhide vm)

Signed-off-by: Ed Santiago <[email protected]>
patrycja-guzik pushed a commit to patrycja-guzik/podman that referenced this pull request Feb 15, 2022
Revert containers#13049. criu-3.16.1-6.fc36 fixes the problem and is
now in fc36 stable:

   https://bodhi.fedoraproject.org/updates/FEDORA-2022-183b337712

(Yes, I confirmed that tests pass on a rawhide vm)

Signed-off-by: Ed Santiago <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants