-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System tests: emergency skip of checkpoint tests #13049
Conversation
...on kernel 5.17, because it's broken Signed-off-by: Ed Santiago <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/hold |
@cevich any idea what's going on here? The |
I forced merge it. |
Damn...that's not right...investigating... |
Yeah, don't always believe the status reported by github. There is a (still) long open bug where it doesn't match what the CI system reports (especially after a re-run). This bug even affects github-actions...no idea why they refuse/can't fix it. Anyway, clicking on it now (in Cirrus WebUI) does show a failure (flake I think):
|
I saw that too. However, looking at the CI results on github itself (both in the Conversation tab and the Checks one) shows all tests green, including the allegedly-failing one. My gut feel is that the test flaked, someone restarted it, then it passed, but Cirrus didn't get the memo that the test passed on rerun. I manually confirmed that the test did pass. I also compared task IDs (or job IDs or whatever, the long number starting with 6) and they were different. |
Wait, you're right (re-run theory) this is somehow a mixup in Cirrus-CI, look closely at the build page: https://cirrus-ci.com/build/5960543587532800 There are TWO entries for |
Revert containers#13049. criu-3.16.1-6.fc36 fixes the problem and is now in fc36 stable: https://bodhi.fedoraproject.org/updates/FEDORA-2022-183b337712 (Yes, I confirmed that tests pass on a rawhide vm) Signed-off-by: Ed Santiago <[email protected]>
Revert containers#13049. criu-3.16.1-6.fc36 fixes the problem and is now in fc36 stable: https://bodhi.fedoraproject.org/updates/FEDORA-2022-183b337712 (Yes, I confirmed that tests pass on a rawhide vm) Signed-off-by: Ed Santiago <[email protected]>
Revert containers#13049. criu-3.16.1-6.fc36 fixes the problem and is now in fc36 stable: https://bodhi.fedoraproject.org/updates/FEDORA-2022-183b337712 (Yes, I confirmed that tests pass on a rawhide vm) Signed-off-by: Ed Santiago <[email protected]>
...on kernel 5.17, because it's broken. Needed for gating tests on rawhide.
Signed-off-by: Ed Santiago [email protected]