Fix build

[lsm5]

Follow up to pr#1086.

Without this change, podman doesn't build with the latest version of
shadow-utils in fedora rawhide and 36.

Signed-off-by: Lokesh Mandvekar [email protected]

@rhatdan @giuseppe @vrothberg @mheon PTAL.

That line was automatically added for me by vim-go when I saved the file.

[lsm5]

shadow-utils 4.11.1 build for rawhide at: https://koji.fedoraproject.org/koji/buildinfo?buildID=1916024

[lsm5]

/cc @baude

[giuseppe]

LGTM

[lsm5]

hang on let me double-check the dependencies again. Don't merge this yet.

[rhatdan]

This will force us to do a vendor dance.

[lsm5]

@rhatdan @giuseppe funny enough, the absence of this patch doesn't affect the rpmbuild, but only affects running make on the podman git repo. Let me try this on a fresh rawhide.

[ikerexxe]

Some additional information. After updating shadow-utils in rawhide I was able to (scratch) build podman as-is in rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=82646117

[rhatdan]

I am in Rawhide and it works for me as well with latest
shadow-utils-2:4.11.1-2.fc36.x86_64

[lsm5]

even after a reboot, I see on podman main branch (commit id: 6d2b54a731cf5ac9a7e760709748ee96a636d65e) :

$ make
CGO_ENABLED=1 GOOS=linux GOARCH=amd64 go build \
	-mod=vendor  \
	-ldflags '-X github.com/containers/podman/v4/libpod/define.gitCommit=6d2b54a731cf5ac9a7e760709748ee96a636d65e -X github.com/containers/podman/v4/libpod/define.buildInfo=1644523124 -X github.com/containers/podman/v4/libpod/config._installPrefix=/usr/local -X github.com/containers/podman/v4/libpod/config._etcDir=/usr/local/etc ' \
	-tags "   selinux systemd libsubid exclude_graphdriver_devicemapper seccomp" \
	-o bin/podman ./cmd/podman
# github.com/containers/podman/v4/cmd/podman
/usr/lib/golang/pkg/tool/linux_amd64/link: running gcc failed: exit status 1
/usr/bin/ld: /tmp/go-link-309536841/000009.o: in function `_cgo_9ca9e583d4f0_Cfunc_subid_get_gid_ranges':
/tmp/go-build/cgo-gcc-prolog:86: undefined reference to `get_subgid_ranges'
/usr/bin/ld: /tmp/go-link-309536841/000009.o: in function `_cgo_9ca9e583d4f0_Cfunc_subid_get_uid_ranges':
/tmp/go-build/cgo-gcc-prolog:106: undefined reference to `get_subuid_ranges'
collect2: error: ld returned 1 exit status

make: *** [Makefile:319: bin/podman] Error 2

I'll create a fresh rawhide instance later and try it out there, but I guess if it's not breaking for others, then this would be low priority if at all. Certainly doesn't look necessary for packaging. Thanks all and sorry about the noise (keeping the PR open for now).

[lsm5]

so this looks like something in my usual rawhide env is messed up because I can't reproduce this on a GCE rawhide instance with the latest shadow-utils-subid-devel. And I see the issue even with this patch, so probably there's some other issues. Anyway, sorry about all the noise once again. Closing ...