-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix use of infra image to clarify default #13064
Conversation
Testing: containers/common#910 |
Note: The consensus on the current behavior was driven by the fact that we'd otherwise keep on pulling the k8s image on existing machines after an update since it was mentioned in containers.conf. @rhatdan can you extend the docs and mention that users need to comment out the infra_image line in containers.conf if they want to build the local image? |
It is not on by default in the containers.conf. It is commented out. So it will NOT pull the image. Nothing by default is commented out. If the user commented it out, then that indicates that they wanted to pull the image. |
Excellent! |
Signed-off-by: Daniel J Walsh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work @rhatdan !
@containers/podman-maintainers PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Daniel J Walsh [email protected]