Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change infra_image default to "" #910

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jan 27, 2022

Signed-off-by: Daniel J Walsh [email protected]

Signed-off-by: Daniel J Walsh <[email protected]>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at #909. I don't want to reiterate on it.

If you really want to do it, please open a PR for Podman because it'll break CI.

@vrothberg
Copy link
Member

Also please see containers/podman#1304 which I asked to do instead.

@rhatdan
Copy link
Member Author

rhatdan commented Jan 30, 2022

@containers/podman-maintainers PTAL
@vrothberg This is ready to go in.

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@flouthoc
Copy link
Collaborator

LGTM

@openshift-merge-robot openshift-merge-robot merged commit 5a03577 into containers:main Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants