-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correction output of podman pod create --help #13043
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: noracenofun The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@TomSweeneyRedHat @rhatdan PTAL
Reminder: Podman builds the local image even if containers.conf sets it to the k8s pause image. The consensus to do that was driven by the fact that we'd otherwise keep on pulling the k8s image on existing machines after an update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heads up: CI will reject the commit as is. Please add [NO NEW TESTS NEEDED]
to the body of the commit.
default infra-image in the message of podman pod create --help corrected [NO NEW TESTS NEEDED] Signed-off-by: noracenofun <[email protected]>
I believe this is wrong, and we should stop using the DefaultInfraImage, it should just be "" to indicate use builtin image. containers/common#910 Should change default. We should work on #13064 |
because of issue #13037
should fixed by #13064
this PR is history
before correction
should be like this after correction
if infra-image set via containers.conf